Skip to content

[Spring] Add new params to support auto binding - #7083

Closed
Moary Chen (moarychan) wants to merge 19 commits into
Azure:mainfrom
moarychan:moary/support-new-params-to-support-auto-binding
Closed

Moary Chen (moarychan) wants to merge 19 commits into
Azure:mainfrom
moarychan:moary/support-new-params-to-support-auto-binding

Conversation

@moarychan

Copy link
Copy Markdown
Member

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • Add arguments --bind-service-registry in spring app create.
  • Add arguments --bind-application-configuration-service in spring app create.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd

azure-client-tools-bot-prd Bot commented Dec 14, 2023

Copy link
Copy Markdown
⚠️Azure CLI Extensions Breaking Change Test
⚠️spring
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd spring app create cmd spring app create added parameter bind_application_configuration_service
⚠️ 1006 - ParaAdd spring app create cmd spring app create added parameter bind_service_registry

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Moary Chen (@moarychan),
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan

Copy link
Copy Markdown
Collaborator

Thank you for your contribution! We will review the pull request and get back to you soon.

@moarychan Moary Chen (moarychan) changed the title Add new params to support auto binding [Spring Add new params to support auto binding Dec 14, 2023
@moarychan Moary Chen (moarychan) changed the title [Spring Add new params to support auto binding [Spring] Add new params to support auto binding Dec 14, 2023
@yonzhan

Copy link
Copy Markdown
Collaborator

Please fix CI issues.

Comment thread src/spring/azext_spring/_validators_enterprise.py Outdated
Comment thread src/spring/azext_spring/_app_factory.py Outdated
@moarychan
Moary Chen (moarychan) marked this pull request as draft December 15, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants