[Spring] Add new params to support auto binding - #7083
Closed
Moary Chen (moarychan) wants to merge 19 commits into
Closed
Moary Chen (moarychan) wants to merge 19 commits into
Moary Chen (moarychan) wants to merge 19 commits into
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| spring app create | cmd spring app create added parameter bind_application_configuration_service |
||
| spring app create | cmd spring app create added parameter bind_service_registry |
|
Hi Moary Chen (@moarychan), |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Yong Zhang (yonzhan)
requested review from
Julie Zhu (yanzhudd) and
Xing Zhou (zhoxing-ms)
December 14, 2023 08:55
Zhe Li (Sneezry)
approved these changes
Dec 15, 2023
Collaborator
|
Please fix CI issues. |
Yuwei Zhou (yuwzho)
approved these changes
Dec 15, 2023
Co-authored-by: Yuwei Zhou <yuwzho@microsoft.com>
Co-authored-by: Yuwei Zhou <yuwzho@microsoft.com>
Moary Chen (moarychan)
marked this pull request as draft
December 15, 2023 08:15
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
--bind-service-registryinspring app create.--bind-application-configuration-serviceinspring app create.General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.