Skip to content

{AKS} Fix azdev style issues for internal files - #7124

Merged
Julie Zhu (yanzhudd) merged 1 commit into
Azure:mainfrom
FumingZhang:fuming/aks-style-p1-1226
Dec 29, 2023
Merged

Julie Zhu (yanzhudd) merged 1 commit into
Azure:mainfrom
FumingZhang:fuming/aks-style-p1-1226

Conversation

@FumingZhang

Copy link
Copy Markdown
Member

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd

azure-client-tools-bot-prd Bot commented Dec 26, 2023

Copy link
Copy Markdown
️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan

Copy link
Copy Markdown
Collaborator

AKS

@yanzhudd

Copy link
Copy Markdown
Contributor

please resolve code conflicts

@yanzhudd

Copy link
Copy Markdown
Contributor

It is better to rerun some related tests to ensure this change would not affect the original logic.

@FumingZhang
FumingZhang force-pushed the fuming/aks-style-p1-1226 branch from bb2bcde to 801340b Compare December 28, 2023 03:18
@FumingZhang

FumingZhang commented Dec 28, 2023

Copy link
Copy Markdown
Member Author

Queued full live test (rerun some failed flaky tests) to validate the change.

Test passed!

@FumingZhang
FumingZhang force-pushed the fuming/aks-style-p1-1226 branch from 801340b to 5271bb9 Compare December 29, 2023 02:51
@yanzhudd
Julie Zhu (yanzhudd) merged commit a0b8a52 into Azure:main Dec 29, 2023
@FumingZhang
FumingZhang deleted the fuming/aks-style-p1-1226 branch January 4, 2024 06:07
Dominque Artura Douglas (ddouglas-msft) pushed a commit to ddouglas-msft/azure-cli-extensions that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants