Skip to content

{AKS} Remove dependency on azure.graphrbac - #7958

Merged
Yishi Wang (evelyn-ys) merged 2 commits into
Azure:mainfrom
FumingZhang:fuming/aks-remove-azuregraphrbac-0906
Sep 9, 2024
Merged

Yishi Wang (evelyn-ys) merged 2 commits into
Azure:mainfrom
FumingZhang:fuming/aks-remove-azuregraphrbac-0906

Conversation

@FumingZhang

@FumingZhang FumingZhang commented Sep 6, 2024

Copy link
Copy Markdown
Member

This checklist is used to make sure that common guidelines for a pull request are followed.

Remove dependency on azure.graphrbac. The removed code is mainly used to help users create a service principal/enterprise application, but it has long been abandoned and is not referenced by any command. In summary, the change will not be noticeable to any user.

Related to #22649, #22174.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd

azure-client-tools-bot-prd Bot commented Sep 6, 2024

Copy link
Copy Markdown
️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan

Copy link
Copy Markdown
Collaborator

AKS

@github-actions

github-actions Bot commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

Hi FumingZhang

Release Suggestions

Module: aks-preview

  • Please log updates into to src/aks-preview/HISTORY.rst
  • Update VERSION to 8.0.0b2 in src/aks-preview/setup.py

Notes

@evelyn-ys

Copy link
Copy Markdown
Contributor

Do you prefer releasing a new version now or waiting for some other features?

@FumingZhang

Copy link
Copy Markdown
Member Author

Could wait other features, the change should be safe and not noticeable to any user, so I didn't leave a note in the history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants