{Packaging} Update sha256sum of install.py - #12106
Merged
Feng Zhou (fengzhou-msft) merged 2 commits intoFeb 11, 2020
Merged
Conversation
Feng Zhou (fengzhou-msft)
requested a review
from Harold Ran (haroldrandom)
as a code owner
February 9, 2020 06:30
Member
Author
|
I found that sha256sum of install.py calculated with git bash on windows is different from on Linux due to the fact that windows converts LF to CRLF for local files at check out (it will convert CRLF back to LF when commit). Since this script is only used on Linux, we should use the sha256sum calculated on Linux, or use LF for files on windows before calculating sha256sum. |
Harold Ran (haroldrandom)
approved these changes
Feb 9, 2020
Collaborator
|
add to S165. |
Yong Zhang (yonzhan)
requested review from
Jiashuo Li (jiasli) and
Myron (mmyyrroonn)
February 9, 2020 08:21
Contributor
|
Followed https://help.ubuntu.com/community/HowToSHA256SUM: |
Jiashuo Li (jiasli)
approved these changes
Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sha256sum of install.py changed due to #12000
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.