[Profile] az login: Add back the warning that a browser is opened - #14505
Merged
Merged
Conversation
Jiashuo Li (jiasli)
requested review from
Arun Sekhar (achandmsft) and
Xiaojian Xu (arrownj)
July 24, 2020 03:52
Collaborator
|
add to S173 |
Closed
Jiashuo Li (jiasli)
marked this pull request as ready for review
October 27, 2020 05:29
Jiashuo Li (jiasli)
requested review from
Zunli Hu (Juliehzl),
Feng Zhou (fengzhou-msft),
Harold Ran (haroldrandom) and
Myron (mmyyrroonn)
as code owners
October 27, 2020 05:29
Yong Zhang (yonzhan)
self-requested a review
October 27, 2020 05:32
Yishi Wang (evelyn-ys)
approved these changes
Oct 29, 2020
Yu Chen (jsntcy)
approved these changes
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert the change in #10851. The removal of the warning message that a browser is opened leads to confusions: MicrosoftDocs/azure-docs-cli#2093, #14473.
If the browser fails to open (due to some unknown reasons), Azure CLI will hang forever and the user won't know what to do next.
With this PR, the warning is shown again:
Testing Guide