[Batch] Fix #15464: Update check for pfx file without password in batch create_certificate - #15509
Merged
Feiyue Yu (qwordy) merged 1 commit intoOct 29, 2020
Conversation
Eirik Zakariassen Fosse (Zay2k)
requested a review
from Brandon Klein (bgklein)
as a code owner
October 13, 2020 18:56
|
Thank you for your contribution Zay2k! We will review the pull request and get back to you soon. |
Contributor
Author
|
An improvement of this would be to do the check with OpenSSL.crypto or similar, like in keyvault module. |
Brandon Klein (bgklein)
approved these changes
Oct 13, 2020
Collaborator
|
Batch |
Member
|
hi Feiyue Yu (@qwordy) , could you pls review the PR? thanks |
Feiyue Yu (qwordy)
approved these changes
Oct 15, 2020
Member
|
hi Eirik Zakariassen Fosse (@Zay2k) Feiyue Yu (@qwordy) what's the status of this PR, is it ok to merge? |
Contributor
Author
It is ok for me. What's the next step, should I merge dev into this, or do you just merge it? |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Eirik Zakariassen Fosse (Zay2k)
deleted the
fix_batch_certificate_password
branch
October 29, 2020 10:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a check for file ending when determining certificate format of certificate uploaded to batch account. When a .pfx-certificate is uploaded without a password, the extra check is needed to not parse it as .cer-file.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.