[Compute] Fix update permission check issue - #15606
Merged
Merged
Conversation
Feiyue Yu (qwordy)
requested a review
from Xiaojian Xu (arrownj)
as a code owner
October 22, 2020 05:25
Yunge Zhu (yungezz)
approved these changes
Oct 22, 2020
Yunge Zhu (yungezz)
left a comment
Member
There was a problem hiding this comment.
LGTM. any test to cover it?
Member
Author
A unit test that checks the request doesn't contain the imageId field is feasible. |
Tony Xu (xuto2)
approved these changes
Oct 22, 2020
Xiaojian Xu (arrownj)
approved these changes
Oct 23, 2020
Tony Xu (xuto2)
approved these changes
Oct 27, 2020
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve #15594
The following operations are braking
az vmss update --name aks-agentpool-13930963-vmss --resource-group MC_adadilli_adadilliSIGNewest_australiaeast --instance-id 0 --protect-from-scale-set-actions False --protect-from-scale-in
az vmss encryption enable --disk-encryption-keyvault adadilliKV3 --name aks-agentpool-13930963-vmss --resource-group MC_adadilli_adadilliSIGNewest_australiaeast
due to the following permission issue:
ForbiddenError: The client has permission to perform action 'Microsoft.Compute/galleries/images/versions/read' on scope '/subscriptions/c1089427-83d3-4286-9f35-5af546a6eb67/resourceGroups/MC_adadilli_adadilliSIGNewest_australiaeast/providers/Microsoft.Compute/virtualMachineScaleSets/aks-agentpool-13930963-vmss/virtualmachines/0', however the current tenant '72f988bf-86f1-41af-91ab-2d7cd011db47' is not authorized to access linked subscription '109a5e88-712a-48ae-9078-9ca8b3c81345'.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.