Skip to content

[Role] az role assignment create: Make description, condition, condition_version preview - #15690

Merged
Jiashuo Li (jiasli) merged 2 commits into
Azure:devfrom
jiasli:assignment-preview
Oct 29, 2020
Merged

[Role] az role assignment create: Make description, condition, condition_version preview#15690
Jiashuo Li (jiasli) merged 2 commits into
Azure:devfrom
jiasli:assignment-preview

Conversation

@jiasli

@jiasli Jiashuo Li (jiasli) commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

Description
Make description, condition, condition_version preview because the public doc is not ready yet.

See email: Detailed document for --condition syntax

Testing Guide

> az role assignment create -h

    --condition         [Preview] : Condition under which the user can be granted
                                    permission.
        Argument '--condition' is in preview. It may be changed/removed in a future
        release.
    --condition-version [Preview] : Version of the condition syntax. If --condition is
                                    specified without --condition-version, default to 2.0.
        Argument '--condition-version' is in preview. It may be changed/removed in a future
        release.
    --description       [Preview] : Description of role assignment.
        Argument '--description' is in preview. It may be changed/removed in a future
        release.

@yonzhan Yong Zhang (yonzhan) added this to the S178 milestone Oct 28, 2020
@yonzhan

Yong Zhang (yonzhan) commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

Role

yonzhan
Yong Zhang (yonzhan) approved these changes Oct 28, 2020
View reviewed changes

@yonzhan Yong Zhang (yonzhan) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiasli Jiashuo Li (jiasli) changed the title [Role] Make description, condition, condition_version preview [Role] az role assignment create: Make description, condition, condition_version preview Oct 29, 2020
@jiasli
Jiashuo Li (jiasli) merged commit 452c022 into Azure:dev Oct 29, 2020
@jiasli
Jiashuo Li (jiasli) deleted the assignment-preview branch October 29, 2020 03:37
@jiasli Jiashuo Li (jiasli) mentioned this pull request Dec 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yonzhan Yong Zhang (yonzhan) yonzhan approved these changes
@jsntcy Yu Chen (jsntcy) Awaiting requested review from jsntcy
+1 more reviewer
@arrownj Xiaojian Xu (arrownj) arrownj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jiasli Jiashuo Li (jiasli)

Labels

None yet

Projects

None yet

Milestone

S178

Development

Successfully merging this pull request may close these issues.

3 participants

@jiasli @yonzhan @arrownj