{Test} Fix live tests for aks, advisor, appconfig, cognitiveservices, cosmosdb, dls, hdinsight, policyinsights, iot, role, security, servicefabric - #15710
Merged
Conversation
| '--dns-name-prefix={dns_name_prefix} --node-count=1 --ssh-key-value={ssh_key_value} ' \ | ||
| '--service-principal={service_principal} --client-secret={client_secret} --enable-addons virtual-node ' \ | ||
| '--aci-subnet-name foo --vnet-subnet-id bar' | ||
| '--aci-subnet-name foo --vnet-subnet-id "{subnet_id}"' |
Member
Author
There was a problem hiding this comment.
There is a validator to check that --vnet-subnet-id should be a resource id.
This test still fails with Operation failed with status: 'Bad Request'. Details: ACI Connector requires azure network plugin, leave that to AKS team to fix.
Bin Ma (bim-msft)
approved these changes
Oct 29, 2020
Feng Zhou (fengzhou-msft)
requested a review
from Feiyue Yu (qwordy)
as a code owner
October 29, 2020 07:49
Feiyue Yu (qwordy)
approved these changes
Oct 29, 2020
Bin Ma (bim-msft)
approved these changes
Oct 30, 2020
Zunli Hu (Juliehzl)
approved these changes
Oct 30, 2020
Zunli Hu (Juliehzl)
left a comment
Contributor
There was a problem hiding this comment.
Approve for code owner part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix some live test failures in aks, advisor, appconfig, cognitiveservices, cosmosdb, dls, hdinsight, policyinsights, iot, role, security, servicefabric
Testing Guide
azdev test
Result from live test pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=594754&view=artifacts&type=publishedArtifacts
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.