[AppService] Fixes #15604, #15605: Add Dotnet5 support by calvinsID · Pull Request #15721 · Azure/azure-cli

calvin (calvinsID) · 2020-10-29T15:43:11Z

Description

Fixes #15604 #15605

Add .NET 5 support for AppService webapps. Runtime dotnet|5.0 can be used with az webapp create and az webapp up

Testing Guide

az webapp list-runtimes (--linux) should show dotnet|5.0 as an available runtime
az webapp up run in a .NET5 app should work and create a dotnet|5.0 webapp
az webapp create --runtime "dotnet|5.0" should create a dotnet|5.0 webapp

Also included bugfixes:

issue WebApp:az webapp create --runtime not idempotent #15701: running az webapp create --runtime "node|12-lts" consecutively with the same webapp should work
Also fixes issue where running az webapp up on an existing webapp with different runtime doesn't update the webapp's runtime

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.

Yunge Zhu (yungezz) · 2020-10-30T00:01:09Z

hi Feiyue Yu (@qwordy) could you pls help to review?

calvin (calvinsID) · 2020-10-30T01:17:28Z

Still testing, will take PR out of draft when done

Feiyue Yu (qwordy) · 2020-10-30T01:46:09Z

OK. Will review after it is done.

Feiyue Yu (qwordy) · 2020-11-03T02:38:41Z

calvin (@calvinsID) Can you help set the target branch to release since you require a hot fix. Thanks.

Byron Tardif (btardif) · 2020-11-04T22:49:52Z

Sisira Panchagnula (@panchagnula) I sign-off on my side. Got to test it out with the private drop I got from calvin (@calvinsID) and everything looks tip-top 🎩

Sisira Panchagnula (panchagnula)

LGTM

Sisira Panchagnula (panchagnula) · 2020-11-05T01:51:12Z

Feiyue Yu (@qwordy) can you help us with the build errors?

Feiyue Yu (qwordy) · 2020-11-05T02:05:56Z

/azp run

azure-pipelines · 2020-11-05T02:06:10Z

Azure Pipelines successfully started running 2 pipeline(s).

Feiyue Yu (qwordy) · 2020-11-05T02:06:48Z

Feiyue Yu (@qwordy) can you help us with the build errors?

The failed task can succeed in other PRs. Let's retry.

Feiyue Yu (qwordy) · 2020-11-05T03:03:56Z

I wrote a PR to fix it: #15804.

Feiyue Yu (qwordy) · 2020-11-06T08:05:57Z

/azp run

azure-pipelines · 2020-11-06T08:06:12Z

Azure Pipelines successfully started running 2 pipeline(s).

Feiyue Yu (qwordy) · 2020-11-06T08:06:16Z

I wrote a PR to fix it: #15804.

It is merged.

…xists' error

… runtime version is different, doesnt update runtime properly

calvin (calvinsID) · 2020-11-07T01:11:25Z

I wrote a PR to fix it: #15804.

It is merged.

thanks Feiyue Yu (@qwordy) , pulled in your changes

Feiyue Yu (qwordy) · 2020-11-09T02:39:44Z

/azp run

azure-pipelines · 2020-11-09T02:39:57Z

Azure Pipelines successfully started running 2 pipeline(s).

…re#15721)

calvin (calvinsID) force-pushed the dotnet5 branch 3 times, most recently from 72e2f79 to 2a6b2ca Compare October 29, 2020 18:25

This was linked to issues Oct 29, 2020

WebApp:az webapp create --runtime not idempotent #15701

Closed

Webapp:.NET 5 support for Runtime Versions #15604

Closed

Webapp:.NET 5 support for az webapp create and az webapp up #15605

Closed

calvin (calvinsID) commented Oct 29, 2020

View reviewed changes

Comment thread src/azure-cli/azure/cli/command_modules/appservice/custom.py Outdated

calvin (calvinsID) commented Oct 29, 2020

View reviewed changes

Comment thread src/azure-cli/azure/cli/command_modules/appservice/custom.py Outdated

Yunge Zhu (yungezz) assigned Feiyue Yu (qwordy) Oct 30, 2020

Yunge Zhu (yungezz) added the Web Apps az webapp label Oct 30, 2020

calvin (calvinsID) commented Oct 30, 2020

View reviewed changes

Comment thread src/azure-cli/azure/cli/command_modules/appservice/custom.py Outdated

calvin (calvinsID) requested a review from Sisira Panchagnula (panchagnula) October 30, 2020 21:33

calvin (calvinsID) changed the base branch from dev to release November 3, 2020 03:09

calvin (calvinsID) changed the base branch from release to dev November 3, 2020 03:11

calvin (calvinsID) force-pushed the dotnet5 branch from 88f330a to 9f4874b Compare November 3, 2020 03:29

calvin (calvinsID) changed the base branch from dev to release November 3, 2020 03:29

calvin (calvinsID) marked this pull request as ready for review November 3, 2020 03:31

calvin (calvinsID) requested review from Zunli Hu (Juliehzl) and Feiyue Yu (qwordy) as code owners November 3, 2020 03:31

calvin (calvinsID) changed the title ~~[AppService] Add Dotnet5 support~~ [AppService] Fixes #15604, #15605: Add Dotnet5 support Nov 5, 2020

Sisira Panchagnula (panchagnula) approved these changes Nov 5, 2020

View reviewed changes

calvin (calvinsID) added 10 commits November 6, 2020 17:10

Add dotnet5

aa75227

Set current_stack property for dotnet 5

810a45c

Separate display name and config for Linux runtime stacks

58f5c1b

Update name to dotnet

8c7959d

Webapp up tests and recordings

493fcbd

Add dotnet5 detection in webapp up, linter errors

d017dbc

Fix bug - 'Parameter with name WEBSITE_NODE_DEFAULT_VERSION already e…

044b2f1

…xists' error

Fix bug where consecutive uses of 'az webapp up' on windows app where…

a2df75f

… runtime version is different, doesnt update runtime properly

Re run webapp up tests

d75bbd5

Move out some stuff to a helper function

b9f96ee

calvin (calvinsID) force-pushed the dotnet5 branch from 9f4874b to b9f96ee Compare November 7, 2020 01:10

Feiyue Yu (qwordy) approved these changes Nov 9, 2020

View reviewed changes

Yunge Zhu (yungezz) merged commit 54cc31d into Azure:release Nov 9, 2020

calvin (calvinsID) added a commit to calvinsID/azure-cli that referenced this pull request Nov 12, 2020

[AppService] Fixes Azure#15604, Azure#15605: Add Dotnet5 support (Azu…

cd85aa5

…re#15721)

Feiyue Yu (qwordy) pushed a commit that referenced this pull request Nov 13, 2020

[AppService] Fixes #15604, #15605: Add Dotnet5 support (#15721) (#15898)

ed82678

Uh oh!

Conversation

calvin (calvinsID) commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yunge Zhu (yungezz) commented Oct 30, 2020

Uh oh!

calvin (calvinsID) commented Oct 30, 2020

Uh oh!

Feiyue Yu (qwordy) commented Oct 30, 2020

Uh oh!

Uh oh!

Feiyue Yu (qwordy) commented Nov 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Byron Tardif (btardif) commented Nov 4, 2020

Uh oh!

Sisira Panchagnula (panchagnula) left a comment

Choose a reason for hiding this comment

Uh oh!

Sisira Panchagnula (panchagnula) commented Nov 5, 2020

Uh oh!

Feiyue Yu (qwordy) commented Nov 5, 2020

Uh oh!

azure-pipelines Bot commented Nov 5, 2020

Uh oh!

Feiyue Yu (qwordy) commented Nov 5, 2020

Uh oh!

Feiyue Yu (qwordy) commented Nov 5, 2020

Uh oh!

Feiyue Yu (qwordy) commented Nov 6, 2020

Uh oh!

azure-pipelines Bot commented Nov 6, 2020

Uh oh!

Feiyue Yu (qwordy) commented Nov 6, 2020

Uh oh!

calvin (calvinsID) commented Nov 7, 2020

Uh oh!

Feiyue Yu (qwordy) commented Nov 9, 2020

Uh oh!

azure-pipelines Bot commented Nov 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

calvin (calvinsID) commented Oct 29, 2020 •

edited

Loading

Feiyue Yu (qwordy) commented Nov 3, 2020 •

edited

Loading