[Network] DNS Record Set Create Updates - #1583
Merged
Merged
Conversation
Travis Prescott (tjprescott)
requested a review
from Yugang Wang (yugangw-msft)
December 15, 2016 23:16
6 tasks
Derek Bekoe (derekbekoe)
approved these changes
Dec 16, 2016
Derek Bekoe (derekbekoe)
left a comment
Member
There was a problem hiding this comment.
LGTM (one small question)
| register_cli_argument('network dns record txt add', 'value', nargs='+') | ||
| register_cli_argument('network dns record txt remove', 'value', nargs='+') | ||
|
|
||
| register_cli_argument('network dns record-set create', 'record_set_type', options_list=('--type', '-t'), help='The type of DNS records in the record set.', **enum_choice_list(modified_record_type)) |
There was a problem hiding this comment.
If this is similar to line 512, create an arg_type and refer to it in both places?
There was a problem hiding this comment.
Help might be different otherwise?
Member
Author
There was a problem hiding this comment.
You can still reference an arg_type and then override a piece of it, so this is a great suggestion. 👍
Kerwin(Kaihui) Sun (00Kai0)
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=367568 Last commit: Azure/azure-cli-extensions@8877ae4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1129 (and pieces of other DNS issues).
dnz record-set create:--metadata,--if-match,--if-none-match-talias for--typeand-zalias for--zone-name