{Packaging} Pin PyJWT to 1.7.1 - #16594
Merged
Merged
Conversation
Jiashuo Li (jiasli)
requested review from
Zunli Hu (Juliehzl),
Yishi Wang (evelyn-ys),
Houk (houk-ms) and
Yu Chen (jsntcy)
as code owners
January 20, 2021 07:37
Collaborator
|
Packaging |
Feng Zhou (fengzhou-msft)
approved these changes
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #16416:
az login --identityfails: load_pem_private_key() missing 1 required positional argument: 'backend'The error is caused by a conflicting dependency on
cryptographyfrom PyJWT 2.0.1https://github.com/jpadilla/pyjwt/blob/3993ce1d3503b58cf74699a89ba9e5c18ef9b556/setup.cfg#L55
and Azure CLI
azure-cli/src/azure-cli/setup.py
Line 134 in 6f25505
There is an ongoing PR #15687 to bump
cryptographyto the latest version.Also the current MSAL 1.8.0 requires
https://github.com/AzureAD/microsoft-authentication-library-for-python/blob/1.8.0/setup.py#L76
Using the old version of
pipmay cause failure.MSAL starts to be compatible with PyJWT 2 since AzureAD/microsoft-authentication-library-for-python#296. Waiting for the next release.