[BACKUP] Fix #14776: Fix --force parameter functionality for az backup vault delete command - #16957
Merged
Feng Zhou (fengzhou-msft) merged 2 commits intoMar 23, 2021
Conversation
Akshay Neema (akshayneema)
requested a review
from Feng Zhou (fengzhou-msft)
as a code owner
February 17, 2021 08:48
Collaborator
|
BACKUP |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
Code owner review required |
Member
|
Feiyue Yu (@qwordy) Akshay Neema (@akshayneema) added both of you as command owners. |
Feng Zhou (fengzhou-msft)
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed --force parameter functionality for az backup vault delete command. Earlier it was only deleting AzureIaaSVM backup management type items. Thereby giving 'Vault cannot be deleted as there are existing resources within the vault' error. Added functionality to delete AzureWorkload and AzureStorage backup management type items and to unregister the respective containers too.
Testing Guide
az backup vault delete -n {vault_name} -g {rg_name} --force
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.