Skip to content

WIP [AKS] az aks create: add enable-encryption-at-host parameter - #17130

Closed
Andy Zhang (andyzhangx) wants to merge 5 commits into
Azure:devfrom
andyzhangx:aks-encryption-at-host
Closed

Andy Zhang (andyzhangx) wants to merge 5 commits into
Azure:devfrom
andyzhangx:aks-encryption-at-host

Conversation

@andyzhangx

@andyzhangx Andy Zhang (andyzhangx) commented Feb 26, 2021

Copy link
Copy Markdown
Contributor

Description

This PR:

  • upgrade aks component to api-version 2020-12-01
  • add enable-encryption-at-host in az aks create and az aks nodepool add

Testing Guide

az aks create -g $RESOURCE_GROUP_NAME -n $CLUSTER_NAME --node-count 1 --node-vm-size Standard_DS2_v2 --generate-ssh-keys --kubernetes-version 1.20.2 --enable-encryption-at-host
az aks nodepool add --name nodepool2 --cluster-name $CLUSTER_NAME --resource-group $RESOURCE_GROUP_NAME --enable-encryption-at-host

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@andyzhangx

Copy link
Copy Markdown
Contributor Author

Feng Zhou (@fengzhou-msft) Yunge Zhu (@yungezz) do you know how to trigger the CI tests? thanks.

@kairu-ms

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@andyzhangx

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 17130 in repo Azure/azure-cli

@andyzhangx

Copy link
Copy Markdown
Contributor Author

kai ru (@kairu-ms) could you help run test again? thanks.

@yungezz

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@andyzhangx

Copy link
Copy Markdown
Contributor Author

would you trigger test again? thanks.

@kairu-ms

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@andyzhangx

Copy link
Copy Markdown
Contributor Author

would you trigger test again? thanks.

@andyzhangx

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 17130 in repo Azure/azure-cli

@andyzhangx

Copy link
Copy Markdown
Contributor Author

kai ru (@kairu-ms)

@yungezz

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@yungezz

Copy link
Copy Markdown
Member

hi Andy Zhang (@andyzhangx) we'll enable permsision to trigger CI pipeline for you soon. Recently Azure CLI got attacked via CI so we temporarily disabled it before solution ready. Pls ping me or Feng Zhou (@fengzhou-msft) for CI need for now. Sorry for inconvinience. :)

@fengzhou-msft

Feng Zhou (fengzhou-msft) commented Mar 16, 2021

Copy link
Copy Markdown
Member

Andy Zhang (@andyzhangx) can you resolve the conflicts and take a look at the CI failures? This PR #17229 bumped API version to 2021-02-01.

@andyzhangx Andy Zhang (andyzhangx) changed the title [AKS] az aks create: add enable-encryption-at-host parameter WIP [AKS] az aks create: add enable-encryption-at-host parameter Mar 16, 2021
@yungezz

Copy link
Copy Markdown
Member

hi Andy Zhang (@andyzhangx) could you pls rebase the PR?

@andyzhangx

Copy link
Copy Markdown
Contributor Author

close this PR since EncryptionAtHost feature GA on AKS is postponed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS az aks/acs/openshift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants