[Storage] Fix #16979: az storage container create fails when providing storage container metadata - #17202
Merged
Conversation
Yishi Wang (evelyn-ys)
requested review from
Zunli Hu (Juliehzl),
Yu Chen (jsntcy) and
Xing Zhou (zhoxing-ms)
as code owners
March 4, 2021 10:20
Collaborator
|
Storage |
Zunli Hu (Juliehzl)
left a comment
Contributor
There was a problem hiding this comment.
Could you add --metadata check?
Contributor
Author
There's no specialized test for |
Zunli Hu (Juliehzl)
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #16979
az storage container createhas command validatorvalidate_client_auth_parameterwhich will suppress all argument validators includingvalidate_metadata. As a result,metadatacan't be parsed properly.Testing Guide
az storage container create -n testcontainer --metadata k1=v1 k2=v2This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.