[SQL] Add Server Trust Group commands - #17275
Merged
Merged
Conversation
bojovicmatija
requested review from
Zunli Hu (Juliehzl),
Yishi Wang (evelyn-ys) and
Jared Moore (jaredmoo)
as code owners
March 10, 2021 23:00
Collaborator
|
SQL |
Contributor
|
Hi bojovicmatija, could you fix CI failure with |
Contributor
Author
fixed |
added 9 commits
March 17, 2021 10:19
bojovicmatija
requested review from
Feng Zhou (fengzhou-msft),
Houk (houk-ms),
Jiashuo Li (jiasli),
Yu Chen (jsntcy) and
kai ru (kairu-ms)
as code owners
March 17, 2021 09:40
bojovicmatija
requested review from
Yuchao Yan (msyyc),
Feiyue Yu (qwordy),
Yunge Zhu (yungezz) and
Xing Zhou (zhoxing-ms)
as code owners
March 17, 2021 09:40
bojovicmatija
force-pushed
the
addingSTGCommands
branch
from
March 17, 2021 09:43
a3052b0 to
2e65027
Compare
Zunli Hu (Juliehzl)
approved these changes
Mar 18, 2021
| g.custom_command('create', 'server_trust_group_create', supports_no_wait=True) | ||
| g.custom_command('delete', 'server_trust_group_delete', confirmation=True, supports_no_wait=True) | ||
| g.custom_show_command('show', 'server_trust_group_get') | ||
| g.custom_command('list', 'server_trust_group_list') |
Contributor
There was a problem hiding this comment.
Could you add wait command according to the guidance?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Server Trust Group commands
Testing Guide
Create a Server Trust Group with specified resource ids of its members.
az sql stg create -g resourcegroup -l location -server-trust-group-name stg-name --trust-scope GlobalTransactions -gm $mi1-id $mi2-idRetrieve a Server Trust Group.
az sql stg show -g resourcegroup -l location -server-trust-group-name stg-nameDelete a Server Trust Group.
az sql stg delete -g resourcegroup -l location -server-trust-group-name stg-nameRetrieve a list of Server Trust Groups by instance.
az sql stg list -g resourcegroup --instance-name mi1-nameRetrieve a list of Server Trust Groups by location.
az sql stg list -g resourcegroup -l locationThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.