{Monitor} az monitor metrics alert update: fix update action issue - #17289
Merged
kai ru (kairu-ms) merged 1 commit intoMar 17, 2021
Merged
Conversation
kai ru (kairu-ms)
requested review from
Yu Chen (jsntcy) and
Yuchao Yan (msyyc)
as code owners
March 12, 2021 05:09
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Collaborator
|
Monitor |
| instance.actions.append(action) | ||
| add_action_ids = {x.action_group_id.lower() for x in add_actions} | ||
| instance.actions = [x for x in instance.actions if x.action_group_id.lower() not in add_action_ids] | ||
| instance.actions.extend(add_actions) |
Member
There was a problem hiding this comment.
No need to use match for webhook_properties now? What does this change mean?
Contributor
Author
There was a problem hiding this comment.
For 'add_actions', the logical of original code is that if that action already exist then update its properties. Now I change the logic, if that action already exist, remove the old one and add the new one.
Yuchao Yan (msyyc)
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #17268
webhook_propertiesproperty has been renamed in SDK. In order to avoid this kind of breaking change, I rewrite the code to eliminate the dependency on this property.Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.