[Storage] az storage fs directory upload/download: Support adls gen2 file system directory upload&download - #17292
Merged
Yishi Wang (evelyn-ys) merged 18 commits intoMar 22, 2021
Conversation
Yishi Wang (evelyn-ys)
requested review from
Zunli Hu (Juliehzl),
Yu Chen (jsntcy) and
Xing Zhou (zhoxing-ms)
March 12, 2021 09:47
Yishi Wang (evelyn-ys)
marked this pull request as draft
March 12, 2021 09:47
Collaborator
|
Storage |
Yishi Wang (evelyn-ys)
marked this pull request as ready for review
March 16, 2021 10:15
Comment on lines
+1599
to
+1601
| file_client = client.get_file_client(file_path=namespace.destination_path) | ||
| try: | ||
| props = file_client.get_file_properties() |
Contributor
There was a problem hiding this comment.
please make sure it works for both file and directory scenario. There are two clients in datalake: FileClient and DirectoryClient.
Contributor
Author
There was a problem hiding this comment.
Yes. Both file and directory can work well with file client. The props returned can distinguish directory from file.
Zunli Hu (Juliehzl)
approved these changes
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature request from #15200
Testing Guide
az storage fs directory uploadaz storage fs directory downloadHistory Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.