Skip to content

[APIM] Fix APIM backup Service #17315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kai ru (kairu-ms) merged 3 commits into from
Mar 18, 2021
Merged

[APIM] Fix APIM backup Service #17315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4e6b11
fix for APIM backup
RupengLiu Mar 16, 2021
8a3e404
Merge branch 'dev' of https://github.com/Azure/azure-cli into dev
RupengLiu Mar 16, 2021
48ae49c
Fix live test
RupengLiu Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/apim/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,13 @@ def load_arguments(self, _):
c.argument('backup_name', help='The name of the backup file to create.')
c.argument('storage_account_name', arg_group='Storage', help='The name of the storage account used to place the backup.')
c.argument('storage_account_key', arg_group='Storage', help='The access key of the storage account used to place the backup.')
c.argument('storage_account_container', options_list=['--storage-account-container', '--container-name'], nargs='+', help='The name of the storage account container used to place the backup.')

@kairu-ms kai ru (kairu-ms) Mar 17, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a breaking change on CLI command interface. Please provide more information to support this change.

@RupengLiu RupengLiu Mar 17, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: #16262, this cli command already broken, need to fix it

c.argument('storage_account_container', options_list=['--storage-account-container', '--container-name'], help='The name of the storage account container used to place the backup.')

with self.argument_context('apim restore') as c:
c.argument('backup_name', help='The name of the backup file to restore.')
c.argument('storage_account_name', arg_group='Storage', help='The name of the storage account used to retrieve the backup from.')
c.argument('storage_account_key', arg_group='Storage', help='The access key of the storage account used to retrieve the backup from.')
c.argument('storage_account_container', options_list=['--storage-account-container', '--container-name'], nargs='+', help='The name of the storage account container used to retrieve the backup from.')
c.argument('storage_account_container', options_list=['--storage-account-container', '--container-name'], help='The name of the storage account container used to retrieve the backup from.')

with self.argument_context('apim api show') as c:
c.argument('service_name', options_list=['--service-name'], help='The name of the API Management service instance.')
Expand Down
Loading