[backup] Fix on demand backup - #17367
Merged
Merged
Conversation
Himanshu Agarwal (hiaga)
requested a review
from Feng Zhou (fengzhou-msft)
as a code owner
March 19, 2021 11:12
Himanshu Agarwal (hiaga)
force-pushed
the
hiaga/SQLBackup
branch
from
March 21, 2021 05:15
7529702 to
8798c2e
Compare
Member
Author
|
Yunge Zhu (@yungezz) , Feng Zhou (@fengzhou-msft), Houk (@houk-ms) : can you please review this PR to fix the on demand backup for SQL and HANA workloads. |
Yunge Zhu (yungezz)
approved these changes
Mar 22, 2021
Feiyue Yu (qwordy)
approved these changes
Mar 22, 2021
Member
Author
|
Feiyue Yu (@qwordy) : I have made the change as suggested, pls review and merge. |
Member
Feng Zhou (@fengzhou-msft) Code owner review required. Please review and merge. |
Himanshu Agarwal (hiaga)
force-pushed
the
hiaga/SQLBackup
branch
from
March 23, 2021 02:18
b6e5ba7 to
1bab713
Compare
Feng Zhou (fengzhou-msft)
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixing on demand backups for SQL workloads - modifying when a user should or shouldn't give the value for retain-until
Testing Guide
az backup protection backup-now -v vaultName -g rgName--backup-management-type AzureWorkload --workload-type MSSQL -c "containerName" -i "itemName" --backup-type "CopyOnlyFull/Full" --retain-until 06-04-2021 --debug
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.