[Core] Use MSAL HTTP cache - #20234
Merged
Merged
Conversation
Jiashuo Li (jiasli)
requested review from
Yishi Wang (evelyn-ys),
Yu Chen (jsntcy),
kai ru (kairu-ms) and
Xing Zhou (zhoxing-ms)
as code owners
November 8, 2021 06:13
Collaborator
|
Core |
Comment on lines
+106
to
118
| def _load_msal_http_cache(self): | ||
| import atexit | ||
| import pickle | ||
|
|
||
| logger.debug("_load_msal_http_cache: %s", self._http_cache_file) | ||
| try: | ||
| with open(self._http_cache_file, 'rb') as f: | ||
| persisted_http_cache = pickle.load(f) # Take a snapshot | ||
| except: # pylint: disable=bare-except | ||
| persisted_http_cache = pickle.load(f) | ||
| except (pickle.UnpicklingError, FileNotFoundError) as ex: | ||
| logger.debug("Failed to load MSAL HTTP cache: %s", ex) | ||
| persisted_http_cache = {} # Ignore a non-exist or corrupted http_cache | ||
| atexit.register(lambda: pickle.dump( | ||
| # When exit, flush it back to the file. |
Contributor
There was a problem hiding this comment.
Yes it is effectively the same as MSAL's recommended pattern. Ship it!
Contributor
Author
There was a problem hiding this comment.
Well, I am a little bit confused. Haven't we decided not to catch EOFError, AttributeError, ImportError, IndexError (AzureAD/microsoft-authentication-library-for-python#407 (comment))? They still appear in https://msal-python.readthedocs.io/en/latest/#publicclientapplication
Contributor
There was a problem hiding this comment.
You are right. I created a new PR in MSAL to remove them. AzureAD/microsoft-authentication-library-for-python#439
Ray Luo (rayluo)
approved these changes
Nov 10, 2021
Zhiyi Huang (calvinhzy)
approved these changes
Nov 12, 2021
Yishi Wang (evelyn-ys)
approved these changes
Nov 15, 2021
kai ru (kairu-ms)
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Incorporate MSAL HTTP cache introduced by AzureAD/microsoft-authentication-library-for-python#407, so that HTTP responses can be cached for
This significantly improves MSAL performance in both normal "get access token" calls and AAD server outages..