Skip to content

{Packaging} Adapt entry script to Mariner: hardcode %{_lib} to lib64 - #20574

Merged
Jiashuo Li (jiasli) merged 1 commit into
Azure:devfrom
jiasli:rpm
Dec 2, 2021
Merged

{Packaging} Adapt entry script to Mariner: hardcode %{_lib} to lib64#20574
Jiashuo Li (jiasli) merged 1 commit into
Azure:devfrom
jiasli:rpm

Conversation

@jiasli

@jiasli Jiashuo Li (jiasli) commented Dec 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

@jiasli Jiashuo Li (jiasli) changed the title {RPM} Adapt entry script to Mariner {Packaging} Adapt entry script to Mariner Dec 1, 2021
@jiasli

Jiashuo Li (jiasli) commented Dec 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

A very valuable post: https://stackoverflow.com/questions/3113472/how-to-make-an-rpm-spec-that-installs-libraries-to-usr-lib-xor-usr-lib64-based. Thanks chalamalasetty.

According to this, if we download a package from https://packages.microsoft.com/yumrepos/azure-cli/ and unzip it, we can see lib64 is already hardcoded when packaging:

image

image

@jiasli Jiashuo Li (jiasli) mentioned this pull request Dec 1, 2021
Merged
3 tasks
@mfrw

Muhammad Falak R Wani (mfrw) commented Dec 1, 2021

Copy link
Copy Markdown
Member

A very valuable post: https://stackoverflow.com/questions/3113472/how-to-make-an-rpm-spec-that-installs-libraries-to-usr-lib-xor-usr-lib64-based. Thanks chalamalasetty.

According to this, if we download a package from https://packages.microsoft.com/yumrepos/azure-cli/ and unzip it, we can see lib64 is already hardcoded when packaging:

image

image

This looks like a win-win :)

@mfrw Muhammad Falak R Wani (mfrw) mentioned this pull request Dec 2, 2021
Merged
3 tasks
mfrw
Muhammad Falak R Wani (mfrw) approved these changes Dec 2, 2021
View reviewed changes

@mfrw Muhammad Falak R Wani (mfrw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you Jiashuo Li (@jiasli)

@jiasli
Jiashuo Li (jiasli) merged commit 52bfbb8 into Azure:dev Dec 2, 2021
@jiasli Jiashuo Li (jiasli) changed the title {Packaging} Adapt entry script to Mariner {Packaging} Adapt entry script to Mariner: hardcode %{_lib} to lib64 Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangzelin007 ZelinWang (wangzelin007) wangzelin007 approved these changes
@kairu-ms kai ru (kairu-ms) Awaiting requested review from kairu-ms
@chasewilson Chase Wilson (chasewilson) Awaiting requested review from chasewilson
@yonzhan Yong Zhang (yonzhan) Awaiting requested review from yonzhan
+1 more reviewer
@mfrw Muhammad Falak R Wani (mfrw) mfrw approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jiasli Jiashuo Li (jiasli)

Labels

Packaging/RPM

Projects

None yet

Milestone

Dec 2021 (2022-01-04)

Development

Successfully merging this pull request may close these issues.

4 participants

@jiasli @mfrw @wangzelin007 @yonzhan