Skip to content

{Packaging} Fix Mariner docker file to build azure-cli rpm cleanly - #20603

Merged
Jiashuo Li (jiasli) merged 1 commit into
Azure:devfrom
chalamalasetty:schalam/marinerdistrofix
Dec 6, 2021
Merged

Jiashuo Li (jiasli) merged 1 commit into
Azure:devfrom
chalamalasetty:schalam/marinerdistrofix

Conversation

@chalamalasetty

@chalamalasetty chalamalasetty commented Dec 3, 2021

Copy link
Copy Markdown
Contributor

Description
Mariner distro azure-cli rpm build is showing issues and not building cleanly because of missing binutils and file packages:

  • strip binary which is a part of binutils package
  • file which is present in file package are used at %__os_install_post phase and required in Mariner image.

Without them, CI for #20584 shows lots of failures:

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1224670&view=logs&j=2d99a3ea-3a85-5049-e806-894016b5c578&t=51344c07-eaf5-5613-2089-f5e3d0d22243&l=732

+ /usr/lib/rpm/brp-strip-unneeded /bin/strip
find: 'file': No such file or directory
find: 'file': No such file or directory
find: 'file': No such file or directory

Adding required binutils and file packages for Mariner Docker file.

Testing Guide
Built locally Mariner variant of azure-cli rpm successfully with no issues.

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@jiasli Jiashuo Li (jiasli) changed the title Fix Mariner docker file to build azure-cli rpm cleanly {Packaging} Fix Mariner docker file to build azure-cli rpm cleanly Dec 3, 2021
Comment thread scripts/release/rpm/Dockerfile.mariner
@jiasli

Copy link
Copy Markdown
Contributor

Confirmed to be working correctly by merging this PR with #20608 and #20584, and push to https://github.com/Azure/azure-cli/tree/mariner:

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1227537&view=logs&j=2d99a3ea-3a85-5049-e806-894016b5c578

image

@jiasli
Jiashuo Li (jiasli) merged commit 10ea4e2 into Azure:dev Dec 6, 2021
Jiashuo Li (jiasli) pushed a commit to jiasli/azure-cli that referenced this pull request Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants