{Core} Update warning message for auth code flow - #21140
Merged
Merged
Conversation
Jiashuo Li (jiasli)
requested review from
Zhiyi Huang (calvinhzy) and
Yishi Wang (evelyn-ys)
as code owners
January 28, 2022 02:08
Collaborator
|
Core |
| # Emit a warning to inform that a browser is opened. | ||
| # Only show the path part of the URL and hide the query string. | ||
| logger.warning("The default web browser has been opened at %s. Please continue the login in the web browser. " | ||
| logger.warning("A web browser has been opened at %s. Please continue the login in the web browser. " |
Contributor
There was a problem hiding this comment.
Good point.
By the way, in an upcoming feature branch, this behavior will likely change again. :-) But that is a topic for future. Right now, I think your PR here makes sense. Approving.
Ray Luo (rayluo)
approved these changes
Jan 28, 2022
Yishi Wang (evelyn-ys)
approved these changes
Jan 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the change of MSAL
The original statement "The default web browser" is no longer true and it causes user confusion:
az loginopens Edge (if installed) instead of default browser on linux #21136This PR updates the warning message according to the latest MSAL behavior.