[Network] Convert Load Balancer and App Gateway Create to Dynamic Templates - #2668
Merged
Travis Prescott (tjprescott) merged 10 commits intoMar 30, 2017
Merged
Conversation
Travis Prescott (tjprescott)
requested a review
from Yugang Wang (yugangw-msft)
March 29, 2017 21:19
10 tasks
Yugang Wang (yugangw-msft)
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM.
Contributor
There was a problem hiding this comment.
This appears a dupe with the same declaration 8 lines above
Contributor
There was a problem hiding this comment.
dupe with the same one 2 lines above?
Contributor
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #2668 +/- ##
==========================================
- Coverage 61.48% 61.14% -0.34%
==========================================
Files 514 480 -34
Lines 26019 25673 -346
Branches 3898 3883 -15
==========================================
- Hits 15997 15698 -299
+ Misses 9079 9048 -31
+ Partials 943 927 -16
Continue to review full report at Codecov.
|
Member
Author
|
Yugang Wang (@yugangw-msft) comments addressed. |
Yugang Wang (yugangw-msft)
approved these changes
Mar 30, 2017
Kerwin(Kaihui) Sun (00Kai0)
pushed a commit
to 00Kai0/azure-cli
that referenced
this pull request
Apr 7, 2021
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=618365 Last commit: Azure/azure-cli-extensions@99130c4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2198.