{Keyvault} Vendor azure-keyvault track1 SDK to make customization for supporting Python 3.11 - #27148
Merged
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Yishi Wang (evelyn-ys)
marked this pull request as draft
August 11, 2023 04:19
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
August 11, 2023 04:19
Collaborator
|
Keyvault |
Yishi Wang (evelyn-ys)
marked this pull request as ready for review
August 15, 2023 06:40
Yishi Wang (evelyn-ys)
requested a review
from ZelinWang (wangzelin007)
as a code owner
August 15, 2023 06:40
Hang (bebound)
approved these changes
Aug 22, 2023
kai ru (kairu-ms)
left a comment
Contributor
There was a problem hiding this comment.
Did you test how many extensions will be affected?
Jiashuo Li (jiasli)
approved these changes
Aug 24, 2023
Contributor
|
Should we use a separate PR to fix the usage of |
Contributor
This is a good point and reminds me that once we start bundling Python 3.11, extensions that don't support Python 3.11 will be broken. |
Contributor
Author
Yes I have triggered extension regression pipeline and manually check the failure extension tests. The failures are not caused by keyvault |
Contributor
Author
Yes I would prefer to let Hang (@bebound) to modify this in #26923 |
Xing Zhou (zhoxing-ms)
approved these changes
Aug 24, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keyvault module now depends on
azure-keyvault(api version2016-10-01and7.0)az keyvault security-domaincommand group (api version7.2)azure-keyvault-keys/azure-keyvault-secrets/azure-keyvault-certificates/azure-keyvault-administrationBut track1 sdk can't work with Python 3.11 because sdk uses
inspect.getargspecwhich has been dropped in Python 3.11.This PR removes public track1 sdk dependency and migrate all related commands to use vendored track1 sdk so that we can customize sdk code to unblock Python 3.11 support as a tmp workaround. Considering track1 sdk is not maintained and won't release new version anymore, our goal is to fully migrate all track1 sdk dependency to track2 which needs to be planned ASAP.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.