Skip to content

Make argument parameters match up. - #2717

Merged
Travis Prescott (tjprescott) merged 1 commit into
Azure:masterfrom
brendandburns:arm2
Apr 5, 2017
Merged

Make argument parameters match up.#2717
Travis Prescott (tjprescott) merged 1 commit into
Azure:masterfrom
brendandburns:arm2

Conversation

@brendandburns

@brendandburns Brendan Burns (brendandburns) commented Apr 3, 2017

Copy link
Copy Markdown
Member

@brendandburns

Brendan Burns (brendandburns) commented Apr 3, 2017

Copy link
Copy Markdown
Member Author

fwiw, this appears to be an unrelated failure:

FAILED (errors=1)
Coverage.py warning: No data was collected.
Coverage.py warning: No data was collected.
Coverage.py warning: No data was collected.
Coverage.py warning: No data was collected.
Coverage.py warning: No data was collected.
Coverage.py warning: No data was collected.
Coverage.py warning: No data was collected.
Coverage.py warning: No data was collected.
Coverage.py warning: No data was collected.
Coverage.py warning: No data was collected.
Coverage.py warning: No data was collected.
==== Test module azure-cli-core result ====
/home/travis/build/Azure/azure-cli/test_results/tests_20170403_163113/nosetests-report.xml
==========

@tjprescott

Travis Prescott (tjprescott) commented Apr 3, 2017

Copy link
Copy Markdown
Member

The error isn't unrelated. You are essentially trying to alias the lock name and the resource name to --name/-n. In this case it should refer to the lock, so --resource-name is fine.

argparse.ArgumentError: argument --name/-n: conflicting option strings: --name, -n

@brendandburns

Brendan Burns (brendandburns) commented Apr 3, 2017 via email

Copy link
Copy Markdown
Member Author

@tjprescott

Travis Prescott (tjprescott) commented Apr 3, 2017

Copy link
Copy Markdown
Member

That test basically runs az -h, which results in all of the help files being loaded. That results in all of the help-related validation being run on all of the commands.

@tjprescott Travis Prescott (tjprescott) mentioned this pull request Apr 3, 2017
Closed
11 tasks
@codecov-io

Codecov (codecov-io) commented Apr 5, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2717 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2717      +/-   ##
==========================================
+ Coverage   61.15%   61.16%   +0.01%     
==========================================
  Files         480      480              
  Lines       25743    25750       +7     
  Branches     3898     3898              
==========================================
+ Hits        15742    15749       +7     
  Misses       9068     9068              
  Partials      933      933
Impacted Files Coverage Δ
...urce/azure/cli/command_modules/resource/_params.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec2149e...243b2bf. Read the comment docs.

tjprescott
Travis Prescott (tjprescott) approved these changes Apr 5, 2017
View reviewed changes

@tjprescott Travis Prescott (tjprescott) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brendan Burns (@brendandburns)!

@tjprescott
Travis Prescott (tjprescott) merged commit 2a73d7f into Azure:master Apr 5, 2017
Johan Stenberg (ex-msft) (johanste) pushed a commit to johanste/azure-cli that referenced this pull request Apr 7, 2017
@brendandburns @johanste
Make argument parameters match up. (Azure#2717)
0ce5336 
Make lock command parameter aliases match up with resource commands.
Travis Prescott (tjprescott) pushed a commit that referenced this pull request Apr 11, 2017
@johanste @tjprescott
Improve performance of package load and command execution (#2819)
4c6cc97 
* Enable delay-load of descriptions for commands (speed up az)

* Update find indexing commands to accept callables for description.

* Command load time in progress

* - Moved previously dead command filter from parser to application configuration.
- Removed unused configuration object/argv on application create.

* Remove unused argument (pylint)

* Remove dummy parameter

* Fix for python 2.7

* Fix yet incorrect passage of parameters

* Fix up additional pylint complaints

* Update tests

* Update tests

* Fix up more tests

* Fix up more core tests

* Enable delay-load of descriptions for commands (speed up az)

* Update find indexing commands to accept callables for description.

* [Network] Remove nulls from VPN connection show/list output (#2748)

* Fix #1615.

* Code review feedback.

* Update test docs for running individual test and all tests in mod (#2763)

* Update test docs for running individual test and all tests in mod

* Made feedback changes

* Make argument parameters match up. (#2717)

Make lock command parameter aliases match up with resource commands.

* [DevTestLabs] Adding scenario test to create simple Linux + Windows VM in lab (#2767)

* WIP create linux + Windows vm in lab

* Adding recording

* Add some more error checking/handling. (#2768)

Add more validation to resolve "lock level" for lock commands.

* Fix doc references to azure.cli.commands (#2740)

* Fix doc references to azure.cli.commands

This module has moved to azure.cli.core.commands

* Fix PyLint

* Add clearer guidelines on modifying changelog (#2739)

* Add clearer guidelines on modifying changelog

* A few smaller changes

* another small format change

* Code review changes

* [DevTestLabs] Exposing commands to manage secrets in the lab (#2691)

* ACS Update: nulling out the windows profile so that there isn't a validation fail… (#2764)

* nulling out the windows profile so that there isn't a valdiation failure for missing password

ACS doesn't return a password on GET. az acs scale command does a GET
then PUT, but since ACS doesn't return the password the verification is
failing before the PUT is sent to ACS.

There is a bug in ACS this exposes. So this shouldn't be merged until
after the ACS rollout finishes. Should be about start of next week.

* updating history

* updating version in history

* removing white space added by editor

* [Compute] Fix issues with VMSS and VM availability set update. (#2773)

* Fix issues with VMSS and VM availability set update.

* Update help. Fix #2762.

* Error out if you try to list resources for a group that doesn't exist. (#2769)

* Minor text fixes (#2776)

* Add docs for az lock update. (#2702)

* [DevTestLab] Explicitly enable usage of saved secrets while lab vm creation (#2686)

* Explicitly enable usage of saved secrets for vm creation

* Better error message with not overriding competing paramters

* Adding export-artifacts commands on formula (#2707)

* core: apply configured defaults on optional arg (#2770)

* Core:apply configured defaults on optional argument

* add a test

* add tests

* update history doc

* address review feedback

* [Network] Support active-active VNet gateways (#2751)

* Start active-active test scenario.

* Add active-active parameter.

* Active-active scenario test 1 (cross premise)

* Add second active-active scenario (vnet-to-vnet)

* Refine active-active gateway configuration.

* Pylint...

* Code review feedback

* Packaged release notes and changes for 0.2.4 (#2735)

* Modify HISTORY.md

* Update Dockerfile

* Update debian also

* Add pip dependencies also

* Command load time in progress

* - Moved previously dead command filter from parser to application configuration.
- Removed unused configuration object/argv on application create.

* Remove unused argument (pylint)

* Remove dummy parameter

* Fix for python 2.7

* Fix yet incorrect passage of parameters

* Fix up additional pylint complaints

* Update tests

* Update tests

* Fix up more tests

* Fix up more core tests

* Improve load time of custom.py for profile, find and configure (speeds up raw az command)

* Pylint + flake8 fixes

* Fix new vm tests that failed due to perf refactoring

* Update redis tests that was broken due to perf refactoring

* Delay-load msrest for command executions that don't need it

* Fix flake8 issues

* Fixing/improving detection of pageable class

* flake8 fixes

* Fix broken merge from upstream/master

* Fix broken merge (again)

* flake8 fixes

* Fix up even more merge errors from last upstream merge

* Flake8 fixes (wrong number of newlines)

* Fix delay load of storage assembly for az

* Update history to reference improved performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tjprescott Travis Prescott (tjprescott) tjprescott approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brendandburns @tjprescott @codecov-io @msftclas @haroldrandom