{Packaging} Fix DEB package build and test - #27541
Merged
Merged
Conversation
🔄AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
Jiashuo Li (jiasli),
ZelinWang (wangzelin007) and
Yong Zhang (yonzhan)
October 8, 2023 07:02
Collaborator
|
Packaging |
Hang (bebound)
marked this pull request as ready for review
October 8, 2023 07:33
Hang (bebound)
requested review from
Zhiyi Huang (calvinhzy) and
kai ru (kairu-ms)
as code owners
October 8, 2023 07:33
Comment on lines
+10
to
+11
| python_minor_version = sys.version_info[1] | ||
| root_dir = f'/opt/az/lib/python3.{python_minor_version}/site-packages/azure/cli/command_modules' |
Contributor
There was a problem hiding this comment.
This is far more elegant than the previous code. Why isn't the failure noticed in #26749?
Jiashuo Li (jiasli)
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some hard-coded path after bump to 3.11 in #26749
dpkg-shlibdeps's executable names.Ref: https://man7.org/linux/man-pages/man1/dpkg-shlibdeps.1.html
command_modulespathTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.