Fix resource parsing and api version lookup. - #2781
Merged
Travis Prescott (tjprescott) merged 2 commits intoApr 7, 2017
Merged
Conversation
Travis Prescott (tjprescott)
left a comment
Member
There was a problem hiding this comment.
Looks like you get "PEP8"ed. 😁 This change looks great to me. I would recommend Johan Stenberg (ex-msft) (@johanste) take a look.
Brendan Burns (brendandburns)
force-pushed
the
resource
branch
from
April 6, 2017 23:19
a2e0571 to
839f0c4
Compare
Member
Author
|
pep8 issues fixed, please take another look. |
Contributor
|
Looks good to me. |
Codecov Report
@@ Coverage Diff @@
## master #2781 +/- ##
==========================================
- Coverage 62.89% 62.89% -0.01%
==========================================
Files 480 480
Lines 25994 25997 +3
Branches 3942 3943 +1
==========================================
+ Hits 16350 16351 +1
- Misses 8617 8622 +5
+ Partials 1027 1024 -3
Continue to review full report at Codecov.
|
Travis Prescott (tjprescott)
approved these changes
Apr 7, 2017
Travis Prescott (tjprescott)
left a comment
Member
There was a problem hiding this comment.
Thanks Brendan Burns (@brendandburns)!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add some tests.
Fixes #2695