vm:load json file correctly for setting extensions - #2790
Merged
Merged
Conversation
|
|
||
| def validate_file_or_dict(string): | ||
| import os | ||
| string = os.path.expanduser(string) |
Contributor
Author
There was a problem hiding this comment.
Rather rollback the change, I prefer to just use validate_file_or_dict for loading extension data, hence i update it to respect the ~
Travis Prescott (tjprescott)
approved these changes
Apr 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix VM/VMSS diagnostics live test failure
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
[] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).Command Guidelines
[ ] Each command and parameter has a meaningful description.(see Authoring Command Modules)