Skip to content

Fix #2830 - subgroups incorrectly shows as commands in help - #2838

Merged
Travis Prescott (tjprescott) merged 1 commit into
Azure:masterfrom
johanste:fix_helpk
Apr 12, 2017
Merged

Travis Prescott (tjprescott) merged 1 commit into
Azure:masterfrom
johanste:fix_helpk

Conversation

@johanste

@johanste Johan Stenberg (ex-msft) (johanste) commented Apr 12, 2017

Copy link
Copy Markdown
Contributor

Fixed regression introduced by the performance work that made the help subsystem confused about commands vs. command groups (we now replace command groups we know won't match the arguments passed in with a dummy command).

Fixes #2830

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • [n/a] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • [n/a ] Each command and parameter has a meaningful description.
  • [n/a] Each new command has a test.

(see Authoring Command Modules)

@johanste Johan Stenberg (ex-msft) (johanste) changed the title Fix #2830 Fix #2830 - subgroups incorrectly shows as commands in help Apr 12, 2017
@codecov-io

Codecov (codecov-io) commented Apr 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #2838 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2838      +/-   ##
==========================================
+ Coverage   62.88%   62.88%   +<.01%     
==========================================
  Files         464      464              
  Lines       25901    25901              
  Branches     3945     3944       -1     
==========================================
+ Hits        16287    16288       +1     
  Misses       8594     8594              
+ Partials     1020     1019       -1
Impacted Files Coverage Δ
src/azure-cli-core/azure/cli/core/application.py 89.32% <100%> (+0.48%) ⬆️
src/azure-cli-core/azure/cli/core/parser.py 81.37% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb1e0d9...991359e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants