Initiate Jenkins pipeline - #2840
Conversation
1. Add build task 2. Add basic performance test task 3. Add performance measure script
Codecov Report
@@ Coverage Diff @@
## master #2840 +/- ##
==========================================
+ Coverage 62.88% 62.92% +0.04%
==========================================
Files 464 464
Lines 25901 25899 -2
Branches 3944 3943 -1
==========================================
+ Hits 16288 16298 +10
+ Misses 8594 8567 -27
- Partials 1019 1034 +15
Continue to review full report at Codecov.
|
| echo "Version number: $version" | ||
|
|
||
| if [ -d /var/build_share ]; then | ||
| echo 'Directory /var/build_share is found. The artifacts will be archieved there.' |
There was a problem hiding this comment.
typo archieved
There was a problem hiding this comment.
will update.
|
|
||
| echo 'Build Azure CLI and its command modules ' | ||
|
|
||
| pip install -r requirements.txt |
There was a problem hiding this comment.
You shouldn't need to install all the requirements just to build.
pip install --upgrade wheel should be sufficient and this is required because you use bdist_wheel below.
| echo "Install build from $build_folder" | ||
|
|
||
| python -m pip install azure-cli --find-links file://$build_folder/artifacts/build -v | ||
| python -m pip list |
There was a problem hiding this comment.
Would suggest pip freeze instead. That output can be easily saved in a file and used later whilst pip list is only user friendly.
There was a problem hiding this comment.
The goal is to print the dependencies in log for human consumption. You think this is good?
There was a problem hiding this comment.
$ pip list
adal (0.4.3)
appdirs (1.4.3)
applicationinsights (0.10.0)
argcomplete (1.8.0)
asn1crypto (0.22.0)
$ pip freeze
adal==0.4.3
appdirs==1.4.3
applicationinsights==0.10.0
argcomplete==1.8.0
asn1crypto==0.22.0
They are both readable but advantage of pip freeze is you can use the output of that into pip install -r ...
|
Derek Bekoe (@derekbekoe) updated. |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)