{Misc.} Improve code style and prepare for pylint 3 - #29373
Merged
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Misc. |
Yong Zhang (yonzhan)
previously approved these changes
Jul 12, 2024
Hang (bebound)
force-pushed
the
update-pylint
branch
from
July 12, 2024 09:03
b38b453 to
5eed1df
Compare
Hang (bebound)
force-pushed
the
update-pylint
branch
from
July 16, 2024 05:34
b08f84c to
636e3b5
Compare
Hang (bebound)
commented
Jul 16, 2024
| def __iter__(self): | ||
| for key in self._data: | ||
| yield key | ||
| yield from self._data |
Contributor
Author
There was a problem hiding this comment.
src/azure-cli-core/azure/cli/core/aaz/_field_value.py:185:8: R1737: Use 'yield from' directly instead of yielding each element one by one (use-yield-from)
Hang (bebound)
commented
Jul 16, 2024
| for idx in self._data: | ||
| if idx + 1 > self._len: | ||
| self._len = idx + 1 | ||
| self._len = max(self._len, idx + 1) |
Contributor
Author
There was a problem hiding this comment.
src/azure-cli-core/azure/cli/core/aaz/_field_value.py:329:16: R1731: Consider using '_len = max(_len, idx + 1)' instead of unnecessary if block (consider-using-max-builtin)
Hang (bebound)
commented
Jul 16, 2024
| partition_count = int(partition_count) | ||
| if replica_count > 0: | ||
| if replica_count > 0: # pylint: disable=consider-using-min-builtin | ||
| instance.replica_count = replica_count |
Contributor
Author
There was a problem hiding this comment.
consider-using-min-builtin should not be raised.
See pylint-dev/pylint#9800
Hang (bebound)
force-pushed
the
update-pylint
branch
from
July 17, 2024 03:00
9ee311f to
43b4630
Compare
Contributor
|
pylint-dev/pylint#9800 was fixed and the fix will be available in next release. |
Contributor
Author
Thanks for the quick fix. Do you have a schedule for the next release? |
Contributor
|
No I don't, but it seems reasonable to say that it will be released shortly, seeing that the milestone has no open issues left and releases are done in 2-3 weeks and the last release was 3 weeks ago. |
Hang (bebound)
force-pushed
the
update-pylint
branch
from
July 22, 2024 06:19
43b4630 to
1f9429c
Compare
Hang (bebound)
commented
Jul 23, 2024
| implicit-str-concat, | ||
| unnecessary-dunder-call, | ||
| # These rules were added in Pylint >= 3.2 | ||
| possibly-used-before-assignment, |
Contributor
Author
There was a problem hiding this comment.
This rule is hard to fix and make the code hard to read.
Hang (bebound)
marked this pull request as ready for review
July 24, 2024 02:09
Hang (bebound)
requested review from
Yu Chen (jsntcy),
kai ru (kairu-ms),
Ethan Yang (necusjz) and
ZelinWang (wangzelin007)
as code owners
July 24, 2024 02:09
Hang (bebound)
requested review from
Zhiyi Huang (calvinhzy),
Julie Zhu (yanzhudd) and
Xing Zhou (zhoxing-ms)
as code owners
July 24, 2024 02:09
Jiashuo Li (jiasli)
approved these changes
Jul 25, 2024
Xing Zhou (zhoxing-ms)
approved these changes
Jul 25, 2024
Contributor
|
Kirstyn Amperiadis (@kamperiadis) Please help review the App Service related code |
Contributor
|
Zubair Abid (@zubairabid) Please help review the Backup related code |
Xing Zhou (zhoxing-ms)
requested review from
Kirstyn Amperiadis (kamperiadis) and
Zubair Abid (zubairabid)
July 25, 2024 06:19
kai ru (kairu-ms)
approved these changes
Jul 25, 2024
Zubair Abid (zubairabid)
approved these changes
Jul 25, 2024
Zubair Abid (zubairabid)
left a comment
Contributor
There was a problem hiding this comment.
Changes in backup code look good to me.
Ethan Yang (necusjz)
approved these changes
Jul 25, 2024
Julie Zhu (yanzhudd)
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for Azure/azure-cli-dev-tools#458