{Packaging} Add warning message for Alpine-based image - #29628
Merged
Merged
Conversation
|
Hi Jiashuo Li (@jiasli), |
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Add global warning message to drive the transition to Azure Linux based image |
microsoft-github-policy-service
Bot
requested a review
from ZelinWang (wangzelin007)
August 1, 2024 10:01
microsoft-github-policy-service
Bot
requested review from
Hang (bebound) and
Yong Zhang (yonzhan)
August 1, 2024 10:01
| "Azure CLI v2.63 is the latest version available on Alpine 10 and will not receive updates. " | ||
| "Consider migrating to the Azure Linux based image for Azure CLI. " | ||
| "For more information: https://docs.microsoft.com/..." | ||
| ) |
Contributor
There was a problem hiding this comment.
The GitHub actions users will see this warning. We'd better to add the instruction to hide the warning.
azure/cli actions also need to migrate to Azure Linux based image in the future.
Shiying Chen (@MoChilia)
Contributor
Author
There was a problem hiding this comment.
az config set core.only_show_errors=true can control this message.
There was a problem hiding this comment.
It's great to use az config to hide this warning message, but it may also hide other warnings. I will first migrate azure/cli action to use Mariner-based image to avoid this warning and ensure the latest azure-cli is available in azure/cli action. Later we may migrate to Azure Linux based image once it's ready.
Contributor
Author
There was a problem hiding this comment.
It's great to use
az configto hide this warning message, but it may also hide other warnings.
I think this is acceptable. I don't want to spend too much effort on this warning message as Alpine-based images will no longer be released/maintained.
Contributor
There was a problem hiding this comment.
Jiashuo Li (@jiasli), isn't it just Alpine and not Alpine 10?
Contributor
There was a problem hiding this comment.
There is no “alpine 10”.
PS: There is Alpine 3.10. But we’re using 3.20 now. I think we can omit the version number in warning message.
| ALPINE_WARNING_MESSAGE = ( | ||
| "Azure CLI v2.63 is the latest version available on Alpine 10 and will not receive updates. " | ||
| "Consider migrating to the Azure Linux based image for Azure CLI. " | ||
| "For more information: https://docs.microsoft.com/..." |
Contributor
Author
There was a problem hiding this comment.
The link is pending MicrosoftDocs/azure-docs-cli#4480.
Jiashuo Li (jiasli)
force-pushed
the
alpine
branch
2 times, most recently
from
August 7, 2024 05:42
fa17d07 to
01ea4a8
Compare
Jiashuo Li (jiasli)
marked this pull request as ready for review
August 7, 2024 05:45
Yishi Wang (evelyn-ys)
approved these changes
Aug 7, 2024
Yishi Wang (evelyn-ys)
approved these changes
Aug 7, 2024
Jiashuo Li (jiasli)
force-pushed
the
alpine
branch
from
August 7, 2024 09:09
76c2f59 to
62cabf6
Compare
Hang (bebound)
approved these changes
Aug 7, 2024
Yishi Wang (evelyn-ys)
approved these changes
Aug 7, 2024
This was referenced Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add global warning message to drive the transition to Azure Linux based image.