{Packaging} Only install pymsalruntime on Windows - #31617
Merged
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
ZelinWang (wangzelin007) and
Yong Zhang (yonzhan)
June 9, 2025 08:08
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MSAL dependency so that the broker extra (pymsalruntime) is only installed on Windows, while non-Windows platforms receive MSAL without the broker extra.
- Split the
msal[broker]requirement into two conditional specifiers based onsys_platform - Ensures Windows installs the broker-enabled MSAL; all other platforms get plain MSAL
Comments suppressed due to low confidence (1)
src/azure-cli-core/setup.py:57
- [nitpick] Add a brief comment above these lines to explain that the broker extra is only installed on Windows, reflecting Azure CLI's current broker support limitation for future maintainers.
'msal[broker]==1.33.0b1; sys_platform == "win32"',
| 'microsoft-security-utilities-secret-masker~=1.0.0b4', | ||
| 'msal-extensions==1.2.0', | ||
| 'msal[broker]==1.33.0b1', | ||
| 'msal[broker]==1.33.0b1; sys_platform == "win32"', |
There was a problem hiding this comment.
[nitpick] Consider defining the MSAL version in a single variable (e.g. msal_version = '1.33.0b1') to avoid duplicating the version string across multiple dependency lines: this makes future updates less error-prone.
Comment on lines
+57
to
+58
| 'msal[broker]==1.33.0b1; sys_platform == "win32"', | ||
| 'msal==1.33.0b1; sys_platform != "win32"', |
Contributor
Author
There was a problem hiding this comment.
MSAL uses platform_system:
pymsalruntime>=0.18,<0.19; python_version>='3.8' and platform_system=='Linux'but I prefer using sys_platform which Azure CLI has be using for a long time:
azure-cli/src/azure-cli-core/setup.py
Line 51 in 9071ce0
azure-cli/src/azure-cli-core/setup.py
Line 62 in 9071ce0
Contributor
|
Need to change |
Ray Luo (rayluo)
approved these changes
Jun 9, 2025
Jiashuo Li (jiasli)
force-pushed
the
pymsalruntime
branch
from
June 9, 2025 10:05
949ba5b to
8ce0884
Compare
Hang (bebound)
approved these changes
Jun 10, 2025
Contributor
Author
|
CI task This seems to be microsoft/azurelinux#13971. |
Contributor
Author
|
CI task |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Nov 25, 2025
Hang (bebound)
added a commit
that referenced
this pull request
Dec 2, 2025
…e to 0.18.1, only install `pymsalruntime` on Windows (#32460)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
msal[broker]1.33.0b1 starts to installpymsalruntimeon Linux (AzureAD/microsoft-authentication-library-for-python#766):but there is some problem with
pymsalruntimethat breaks the package build process on various Linux distributions: #31563 (comment).As Azure CLI currently only supports broker on Windows, we only install
pymsalruntimeon Windows.See