Skip to content

Verify command packages have the wheel extension applied - #3230

Merged
Derek Bekoe (derekbekoe) merged 2 commits into
Azure:masterfrom
derekbekoe:verify-wheels
May 8, 2017
Merged

Derek Bekoe (derekbekoe) merged 2 commits into
Azure:masterfrom
derekbekoe:verify-wheels

Conversation

@derekbekoe

Copy link
Copy Markdown
Member

Verifies the following as part of CI:

A valid command module .whl for the CLI should:

  • Not contain any init.py files in directories above azure.cli.command_modules.

Does the package have a azure_bdist_wheel.py file?
Does the package have a setup.cfg file?
Does setup.py include 'cmdclass=cmdclass'?


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • [n/a] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • [n/a] Each command and parameter has a meaningful description.
  • [n/a] Each new command has a test.

(see Authoring Command Modules)

@codecov-io

Codecov (codecov-io) commented May 6, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3230 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3230      +/-   ##
==========================================
- Coverage   70.35%   70.27%   -0.08%     
==========================================
  Files         381      391      +10     
  Lines       24777    25068     +291     
  Branches     3785     3811      +26     
==========================================
+ Hits        17431    17617     +186     
- Misses       6237     6342     +105     
  Partials     1109     1109
Impacted Files Coverage Δ
...ure/cli/command_modules/cognitiveservices/_help.py 100% <0%> (ø) ⬆️
...li-core/azure/cli/core/test_utils/vcr_test_base.py
...-rdbms/azure/cli/command_modules/rdbms/commands.py 89.79% <0%> (ø)
...-cli-rdbms/azure/cli/command_modules/rdbms/help.py 100% <0%> (ø)
...ure-cli-testsdk/azure/cli/testsdk/vcr_test_base.py 69.18% <0%> (ø)
...li-rdbms/azure/cli/command_modules/rdbms/params.py 100% <0%> (ø)
...mand_modules/azure-cli-rdbms/azure/cli/__init__.py 100% <0%> (ø)
.../command_modules/azure-cli-rdbms/azure/__init__.py 100% <0%> (ø)
...li-rdbms/azure/cli/command_modules/rdbms/custom.py 11.47% <0%> (ø)
...cli-rdbms/azure/cli/command_modules/rdbms/_util.py 48.93% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf2a6a3...ad422bd. Read the comment docs.

@derekbekoe

Copy link
Copy Markdown
Member Author

Johan Stenberg (ex-msft) (@johanste) Does this look good to you?

# STEP 4:: Verify the wheels that get produced
print_heading('Verifying wheels...')
invalid_wheels = []
for wheel_path in glob.glob(built_packages_dir + '/*.whl'):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, using path.join is the right thing to do.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick. Other than that, looks good. You could consider printing which init.py file was included in the package, but that is not required (it's not that hard to crack open the wheel after all)

@derekbekoe

Copy link
Copy Markdown
Member Author

Johan Stenberg (ex-msft) (@johanste) feedback addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants