Verify command packages have the wheel extension applied - #3230
Conversation
2814439 to
8466655
Compare
Codecov Report
@@ Coverage Diff @@
## master #3230 +/- ##
==========================================
- Coverage 70.35% 70.27% -0.08%
==========================================
Files 381 391 +10
Lines 24777 25068 +291
Branches 3785 3811 +26
==========================================
+ Hits 17431 17617 +186
- Misses 6237 6342 +105
Partials 1109 1109
Continue to review full report at Codecov.
|
|
Johan Stenberg (ex-msft) (@johanste) Does this look good to you? |
| # STEP 4:: Verify the wheels that get produced | ||
| print_heading('Verifying wheels...') | ||
| invalid_wheels = [] | ||
| for wheel_path in glob.glob(built_packages_dir + '/*.whl'): |
There was a problem hiding this comment.
Technically, using path.join is the right thing to do.
Johan Stenberg (ex-msft) (johanste)
left a comment
There was a problem hiding this comment.
One minor nitpick. Other than that, looks good. You could consider printing which init.py file was included in the package, but that is not required (it's not that hard to crack open the wheel after all)
|
Johan Stenberg (ex-msft) (@johanste) feedback addressed. |
Verifies the following as part of CI:
A valid command module .whl for the CLI should:
Does the package have a azure_bdist_wheel.py file?
Does the package have a setup.cfg file?
Does setup.py include 'cmdclass=cmdclass'?
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)