{ACR} Disable test temporarily to unblock CI checks - #33060
Merged
Merged
Conversation
Julie Zhu (yanzhudd)
requested review from
NoriZC and
Teresa Ritorto (teresaritorto)
as code owners
March 26, 2026 04:58
️✔️AzureCLI-FullTest
|
|
Hi Julie Zhu (@yanzhudd), |
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Julie Zhu (yanzhudd)
force-pushed
the
re-recording
branch
from
March 26, 2026 08:22
aca851d to
e3aee0f
Compare
Contributor
Author
|
Hi Bin Du (@northtyphoon) Rodrigo Mendoza (@rosanch) |
NoriZC
approved these changes
Mar 26, 2026
Contributor
|
🔔 Routing this PR to @act-observability-squad. |
nihalvar
added a commit
to nihalvar/azure-cli
that referenced
this pull request
Jun 4, 2026
PR Azure#33060 added @live_only() to skip this test in replay mode after the SDK split in PR Azure#33017 (azure-mgmt-containerregistry 15.1.0b1) converted RegistriesOperations.update into an async LRO (begin_update). The caller in connected_registry.py kept using the returned poller as a finished result, so the cassette stopped matching real traffic. PR Azure#33040 already shipped the real fix on dev: it wraps acr_update_set in LongRunningOperation(cmd.cli_ctx)(...) and refreshes the cassette with the LRO polling interactions. The test passes in replay mode against current dev (verified locally, ~14s). This change drops the now-unnecessary @live_only() decorator and its unused import.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.