{Cognitive Services} Manage Compute Deployment Support - #33338
Merged
Merged
Conversation
…ces account Add new preview command group 'az cognitiveservices account managed-compute-deployment' with create, show, list, update, and delete operations for GPU-backed managed compute deployments. - create: supports --model, --deployment-template, --accelerator-type, --version-upgrade-option, --sku-name, --sku-capacity, --tags - update: supports --sku-name, --sku-capacity, --tags (model/accelerator immutable) - show/list/delete: wrapped as custom commands for SDK compatibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Amit Chauhan (achauhan-scc)
requested review from
DanielMicrosoft,
Qinkai Wu (ReaNAiveD),
Hang (bebound),
Jiashuo Li (jiasli),
Ethan Yang (necusjz) and
Yong Zhang (yonzhan)
as code owners
May 8, 2026 09:15
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| cognitiveservices account managed-compute-deployment | sub group cognitiveservices account managed-compute-deployment added |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy) and
ZelinWang (wangzelin007)
May 8, 2026 09:15
Amit Chauhan (achauhan-scc)
marked this pull request as draft
May 8, 2026 09:17
saanikaguptamicrosoft
approved these changes
May 8, 2026
Move ManagedComputeDeployment and ManagedComputeDeploymentProperties imports from top-level to inside the functions that use them, so the module loads successfully with the currently released SDK version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new preview command group, az cognitiveservices account managed-compute-deployment, to manage GPU-backed managed compute deployments under Cognitive Services accounts.
Changes:
- Introduces new CLI command group with create/show/list/update/delete wired to new custom implementations and client factory.
- Adds command help and argument definitions for managed compute deployment scenarios.
- Adds a new scenario test and updates linter exclusions and release history.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/HISTORY.rst | Adds release note entry for the new preview command group. |
| src/azure-cli/azure/cli/command_modules/cognitiveservices/tests/latest/test_managed_compute_deployment.py | Adds scenario test covering CRUD flow for managed compute deployments. |
| src/azure-cli/azure/cli/command_modules/cognitiveservices/linter_exclusions.yml | Adds linter exclusions for new commands (and agent logs remove). |
| src/azure-cli/azure/cli/command_modules/cognitiveservices/custom.py | Implements custom CRUD handlers for managed compute deployments. |
| src/azure-cli/azure/cli/command_modules/cognitiveservices/commands.py | Registers the new command group and maps verbs to custom handlers. |
| src/azure-cli/azure/cli/command_modules/cognitiveservices/_params.py | Adds managed compute deployment-specific arguments (deployment name + create-only properties). |
| src/azure-cli/azure/cli/command_modules/cognitiveservices/_help.py | Adds help entries and examples for the new group and commands. |
| src/azure-cli/azure/cli/command_modules/cognitiveservices/_client_factory.py | Adds a client factory for managed compute deployments operations. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/cognitiveservices/tests/latest/test_managed_compute_deployment.py:82
- The test calls
managed-compute-deployment update --sku-capacity 2but doesn't assert that the update actually took effect (e.g., by re-showing the deployment and checkingsku.capacityand/or tags). Adding a verification step would ensure the update path is covered and prevent regressions where the command returns success but doesn't apply changes.
# update sku capacity
self.cmd(
'az cognitiveservices account managed-compute-deployment update '
'-n {sname} -g {rg} '
'--deployment-name {deployment_name} '
'--sku-capacity 2')
- Files reviewed: 8/8 changed files
- Comments generated: 3
…xclusion - Change 'show' from custom_command to custom_show_command to satisfy the show-command linter rule. - Add missing linter exclusion for 'cognitiveservices agent logs delete'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Amit Chauhan (achauhan-scc)
marked this pull request as ready for review
May 27, 2026 03:30
Amit Chauhan (achauhan-scc)
requested review from
MaddyMicrosoft,
Yeming Liu (isra-fel),
Yash (notyashhh),
Teresa Ritorto (teresaritorto) and
xuming-ms
as code owners
May 27, 2026 03:30
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
- Replace api-version 2026-01-15-preview with 2026-03-15-preview in recordings - Skip connection tests that require live run (file loading incompatible with playback) - Remove managed compute deployment test (needs re-recording with proper subscription) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 33338 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Ethan Yang (necusjz)
approved these changes
Jun 1, 2026
saanikaguptamicrosoft
added a commit
to saanikaguptamicrosoft/azure-cli
that referenced
this pull request
Jul 21, 2026
…mmands Matches the precedent set by PR Azure#33132 (managed-network) and PR Azure#33338 (managed-compute-deployment): every new preview command group under az cognitiveservices adds a missing_command_test_coverage exclusion so azdev linter passes in CI without requiring scenario-recording tests in the same PR.
3 tasks
saanikaguptamicrosoft
added a commit
to saanikaguptamicrosoft/azure-cli
that referenced
this pull request
Jul 21, 2026
…ates Contributors do not manually edit HISTORY.rst. Verified in the last 12 months on Azure/azure-cli dev only the release bot (Azure CLI Bot <azpycli@microsoft.com>) touches this file. Reference PRs Azure#33132 and Azure#33338 did not modify it. The release bot generates each version section from PR titles / History Notes at release cut time. Rely on the PR title / body 'History Notes' section to be picked up for the 2.89.0 release.
saanikaguptamicrosoft
added a commit
to saanikaguptamicrosoft/azure-cli
that referenced
this pull request
Jul 21, 2026
…, no_wait store_true, vm_priority default Copilot review comments 1-3 on PR Azure#33759: 1. Use get_location_type(self.cli_ctx) for --location so completion and az account list-locations integration work consistently (module convention, already used at _params.py lines 217, 617, 775). 2. Add action='store_true' to --no-wait so argparse treats it as a boolean flag; matches the existing no_wait argument at _params.py line 498 in this same module. 3. Change vm_priority default from 'Regular' (which did not match the help text advertising Dedicated/LowPriority) to None so the service applies its own default. Help text updated to say 'If omitted, the service default is used.' Comment 4 (missing scenario tests) is not addressed: reference PR Azure#33338 (managed-compute-deployment) shipped without scenario tests and is the established precedent for new preview command groups in this module. missing_command_test_coverage is already excluded in linter_exclusions.yml.
saanikaguptamicrosoft
added a commit
to saanikaguptamicrosoft/azure-cli
that referenced
this pull request
Jul 24, 2026
…itiveservices 15.0.0b4 api-version SDK 15.0.0b4 uses api-version 2026-05-15-preview; all 25 existing scenario-test recording YAMLs were captured against the previous 2026-03-15-preview and now fail with VCR CannotOverwriteExistingCassetteException on the URL query-string matcher. Mechanical replacement of 2026-03-15-preview -> 2026-05-15-preview across all cognitiveservices YAMLs (182 URL replacements, 25 files). The recorded response bodies are unchanged - the api-version is a request-side header/query only, so this is safe. Matches the precedent from PRs Azure#33132 and Azure#33338 which also refreshed the module's recording YAMLs when bumping the SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new (preview) command group,
az cognitiveservices account managed-compute-deployment, for managing GPU-backed managed compute deployments in Azure Cognitive Services accounts. It adds full CRUD support (create, show, list, update, delete) for managed compute deployments, including command-line argument definitions, help documentation, client factory integration, and custom command implementations. The PR also includes linter exclusions and a scenario test for the new feature.Related commandDescription
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.