[Container app] Fix #33369: az containerapp up: Resolve OS/Architecture models from correct SDK package - #33371
Merged
Julie Zhu (yanzhudd) merged 1 commit intoMay 26, 2026
Conversation
…om correct SDK package queue_acr_build() resolves OS and Architecture models from MGMT_CONTAINERREGISTRY, but these models have moved to the azure-mgmt-containerregistrytasks package. This causes cmd.get_models() to return None, crashing with: AttributeError: 'NoneType' object has no attribute 'linux' Update both get_models() calls to use MGMT_CONTAINERREGISTRYTASKS which is already a dependency and contains the correct models. Fixes Azure#33369
Vlad Lyga (lygav)
requested review from
Greedygre (Greedygre),
Zunli Hu (Juliehzl),
NoriZC,
Hong Wang (howang-ms),
Teresa Ritorto (teresaritorto) and
Julie Zhu (yanzhudd)
as code owners
May 13, 2026 13:07
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
JennyLawrance,
Vincent He (chinadragon0515),
Eben Carek (ebencarek),
Jitin John (jijohn14),
Yu Chen (jsntcy),
Alok Pagariya (pagariyaalok),
Ruslan Yakushev (ruslany),
Sanchit Mehta (sanchitmehta),
Tomer Rosenthal (torosent),
Vini Soto (vinisoto),
Vaclav Turecek (vturecek),
ZelinWang (wangzelin007),
Yong Zhang (yonzhan) and
Xing Zhou (zhoxing-ms)
May 13, 2026 13:07
Contributor
|
Thank you for your contribution Vlad Lyga (@lygav)! We will review the pull request and get back to you soon. |
containerapp up --source crash: resolve OS/Architecture models from correct SDK packageaz containerapp up --source crash: resolve OS/Architecture models from correct SDK package
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in az containerapp up --source during ACR build queuing by resolving OS, Architecture, DockerBuildRequest, and PlatformProperties from the correct SDK (azure-mgmt-containerregistrytasks) via ResourceType.MGMT_CONTAINERREGISTRYTASKS, avoiding cmd.get_models() returning None.
Changes:
- Update
queue_acr_build()to loadOS/Architecturemodels fromMGMT_CONTAINERREGISTRYTASKSinstead ofMGMT_CONTAINERREGISTRY. - Update
queue_acr_build()to loadDockerBuildRequest/PlatformPropertiesmodels fromMGMT_CONTAINERREGISTRYTASKSinstead ofMGMT_CONTAINERREGISTRY.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
az containerapp up --source crash: resolve OS/Architecture models from correct SDK packageaz containerapp up --source crash: resolve OS/Architecture models from correct SDK package
Contributor
|
Hi Vlad Lyga (@lygav) |
Contributor
Author
|
Julie Zhu (@yanzhudd) Hi, yes it is ready for review |
az containerapp up --source crash: resolve OS/Architecture models from correct SDK packageaz containerapp up: Resolve OS/Architecture models from correct SDK package
az containerapp up: Resolve OS/Architecture models from correct SDK packageaz containerapp up: Resolve OS/Architecture models from correct SDK package
Julie Zhu (yanzhudd)
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp up --sourceDescription
az containerapp up --source .crashes withAttributeError: 'NoneType' object has no attribute 'linux'becausequeue_acr_build()in_utils.pyresolvesOS,Architecture,DockerBuildRequest, andPlatformPropertiesmodels viacmd.get_models()usingResourceType.MGMT_CONTAINERREGISTRYwithoperation_group='runs'.These models have moved to the
azure-mgmt-containerregistrytasksSDK package, socmd.get_models()silently returnsNone, and the subsequentOS.linux.valuecall crashes.This PR updates both
get_models()calls inqueue_acr_build()to useResourceType.MGMT_CONTAINERREGISTRYTASKS, which is already a declared dependency and contains the correct models.Testing Guide
The existing
@live_onlytests intest_containerapp_compose_registries.pycoverqueue_acr_buildand would validate this fix in the nightly live test run.History Notes
[Container app] Fix #33369:
az containerapp up: Resolve OS/Architecture models from correct SDK packageThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.