[MySQL] Fix #32827: Restore Memory Optimized tier terminology

[ShawnX (ShawnXxy)]

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes	Tests
⚠️ None	️✔️ 130/130

⚠️AzureCLI-BreakingChangeTest

⚠️mysql

rule	cmd_name	rule_message	suggest_message
⚠️ 1008 - ParaPropAdd	mysql flexible-server create	cmd mysql flexible-server create update parameter tier: added property type=custom_type
⚠️ 1008 - ParaPropAdd	mysql flexible-server geo-restore	cmd mysql flexible-server geo-restore update parameter tier: added property type=custom_type
⚠️ 1008 - ParaPropAdd	mysql flexible-server import create	cmd mysql flexible-server import create update parameter tier: added property type=custom_type
⚠️ 1008 - ParaPropAdd	mysql flexible-server replica create	cmd mysql flexible-server replica create update parameter tier: added property type=custom_type
⚠️ 1008 - ParaPropAdd	mysql flexible-server restore	cmd mysql flexible-server restore update parameter tier: added property type=custom_type
⚠️ 1008 - ParaPropAdd	mysql flexible-server update	cmd mysql flexible-server update update parameter tier: added property type=custom_type

Related command

Description

Addressing #32827 .

It was initially introduced in PR #22241 for business requirement.

Changes for wordings in below two commits of this PR:
1- commit 1c25ad2e5a Using "MemoryOptimized" for tier name but also accept "BusinessCritical" backward compatibility for legacy term
2-commit b4c7c9d9b8 Update help text for parameter "--accelerated-logs" that is supported both GeneralPurpose and MemoryOptimized tier now, which was introduced in feature PR #29936

Testing Guide

Text checks

$commands = @('create', 'restore', 'geo-restore', 'update')

foreach ($command in $commands) {
    $help = (& .\.venv\Scripts\az.bat mysql flexible-server $command --help 2>&1) -join "`n"

    [pscustomobject]@{
        Command          = $command
        MemoryOptimized  = $help -match 'Memory\s+Optimized'
        BusinessCritical = $help -match 'Business\s+Critical'
    }
}

Regression test

.\.venv\Scripts\python.exe -m pytest `
  src\azure-cli\azure\cli\command_modules\mysql\tests\latest\test_mysql_custom.py -q

Module checks

$env:VIRTUAL_ENV = (Resolve-Path .venv).Path

.\.venv\Scripts\azdev.exe style mysql --pylint --pep8
.\.venv\Scripts\azdev.exe linter mysql --min-severity high

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

🟡 Changes recommended

Backward-compatibility for --tier BusinessCritical appears incomplete (restore/georestore still validate without normalization), and the updated --accelerated-logs help omits the tier-dependent default behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates Azure MySQL Flexible Server CLI terminology to use “MemoryOptimized” (instead of “BusinessCritical”) while keeping legacy support, and adjusts related UX/help/tests in the mysql command module.

Changes:

• Normalize --tier BusinessCritical to MemoryOptimized for create/import/update flows.
• Stop rewriting the tier name in flexible-server list-skus so it preserves MemoryOptimized.
• Update --accelerated-logs help text and add unit coverage for accelerated-logs tier behavior and list-skus tier naming.

File summaries

File	Description
src/azure-cli/azure/cli/command_modules/mysql/tests/latest/test_mysql_custom.py	Adds unit tests for accelerated logs tier defaults and for list-skus preserving MemoryOptimized.
src/azure-cli/azure/cli/command_modules/mysql/custom.py	Adds legacy alias mapping in several command flows and changes list-skus to return raw tier names.
src/azure-cli/azure/cli/command_modules/mysql/_validators.py	Updates tier-related error messaging to “Memory Optimized”.
src/azure-cli/azure/cli/command_modules/mysql/_util.py	Removes tier-rewrite helper so list-skus no longer transforms MemoryOptimized to BusinessCritical.
src/azure-cli/azure/cli/command_modules/mysql/_params.py	Updates --accelerated-logs help text to reflect new tier support.

Review details

• Files reviewed: 5/5 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Aditya Pujara (a0x1ab)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).

[Yong Zhang (yonzhan)]

mysql

[Aditya Pujara (a0x1ab)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).

[ShawnX (ShawnXxy)]

Yong Zhang (@yonzhan) Ethan Yang (@necusjz) could we check this so we can still checkin in October train? Thanks.

[Yong Zhang (yonzhan)]

Please fix CI issues

[ShawnX (ShawnXxy)]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 34019 in repo Azure/azure-cli

[ShawnX (ShawnXxy)]

Please fix CI issues

Yong Zhang (@yonzhan) check the failure log, it is about the title format. I have updated the title but lack of privileges to trigger a new validation