Ensure skip cert check when sending out raw requests if related env var is configured - #5328
Merged
Merged
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5328 |
Yugang Wang (yugangw-msft)
force-pushed
the
proxy
branch
from
January 17, 2018 20:20
4a96022 to
e6725bf
Compare
Member
|
Thank you Yugang Wang (@yugangw-msft) Please go ahead with updating acr code. |
Member
|
|
Yugang Wang (yugangw-msft)
force-pushed
the
proxy
branch
from
January 18, 2018 22:31
fd10a08 to
d4a74f4
Compare
Derek Bekoe (derekbekoe)
approved these changes
Jan 18, 2018
3 tasks
Contributor
Author
|
Derek Bekoe (@derekbekoe) Dongjiang You (@djyou), thanks for the review. I have tried |
Comment on lines
-81
to
+83
| txt = urlopen(target_url).read() | ||
| dic = json.loads(txt.decode()) | ||
| # under hack mode(say through proxies with unsigned cert), opt out the cert verification | ||
| response = requests.get(target_url, verify=(not should_disable_connection_verify())) |
Contributor
There was a problem hiding this comment.
This is where urlopen was modified
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5099. Fix #5258
Derek Bekoe (@derekbekoe), I can also update related extension code. So let me know
Dongjiang You (@djyou), I can update acr code. So let me know
Moving forward, during code review, for any HTTTPS raw requests outside of Python SDK, we just ensure the new code checks the global flag
Command Guidelines
(see Authoring Command Modules)