Skip to content

cmd: use plurals for list-* command naming #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yugang Wang (yugangw-msft) merged 1 commit into from
Aug 30, 2016
Merged

cmd: use plurals for list-* command naming #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/command_modules/azure-cli-network/azure/cli/command_modules/network/generated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@
cli_command('network express-route circuit delete', ExpressRouteCircuitsOperations.delete, factory)
cli_command('network express-route circuit show', ExpressRouteCircuitsOperations.get, factory)
cli_command('network express-route circuit get-stats', ExpressRouteCircuitsOperations.get_stats, factory)
cli_command('network express-route circuit list-arp', ExpressRouteCircuitsOperations.list_arp_table, factory)
cli_command('network express-route circuit list-routes', ExpressRouteCircuitsOperations.list_routes_table, factory)
cli_command('network express-route circuit list-arp-tables', ExpressRouteCircuitsOperations.list_arp_table, factory)
cli_command('network express-route circuit list-route-tables', ExpressRouteCircuitsOperations.list_routes_table, factory)
cli_command('network express-route circuit list', list_express_route_circuits)
cli_generic_update_command('network express-route circuit update', ExpressRouteCircuitsOperations.get, ExpressRouteCircuitsOperations.create_or_update, factory)

Expand Down
4 changes: 2 additions & 2 deletions ...odules/azure-cli-network/azure/cli/command_modules/network/tests/test_network_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,9 @@ def body(self):
rg, ern, pv), allowed_exceptions=allowed_exceptions)
self.cmd('network express-route circuit-peering show --resource-group {0} --circuit-name {1} --name {2}'.format(
rg, ern, pv), allowed_exceptions=allowed_exceptions)
self.cmd('network express-route circuit list-arp --resource-group {0} --name {1} --peering-name {2} --device-path {2}'.format(
self.cmd('network express-route circuit list-arp-tables --resource-group {0} --name {1} --peering-name {2} --device-path {2}'.format(
rg, ern, pv), allowed_exceptions=allowed_exceptions)
self.cmd('network express-route circuit list-routes --resource-group {0} --name {1} --peering-name {2} --device-path {2}'.format(
self.cmd('network express-route circuit list-route-tables --resource-group {0} --name {1} --peering-name {2} --device-path {2}'.format(
rg, ern, pv), allowed_exceptions=allowed_exceptions)

class NetworkLoadBalancerScenarioTest(ResourceGroupVCRTestBase):
Expand Down
2 changes: 1 addition & 1 deletion src/command_modules/azure-cli-profile/azure/cli/command_modules/profile/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def logout(username=None):
username = profile.get_current_account_user()
profile.logout(username)

def list_location():
def list_locations():
from azure.cli.commands.parameters import get_subscription_locations
return get_subscription_locations()

4 changes: 2 additions & 2 deletions src/command_modules/azure-cli-profile/azure/cli/command_modules/profile/generated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from .custom import (login,
logout,
list_location,
list_locations,
list_subscriptions,
set_active_subscription,
account_clear)
Expand All @@ -20,5 +20,5 @@
cli_command('account list', list_subscriptions)
cli_command('account set', set_active_subscription)
cli_command('account clear', account_clear)
cli_command('account list-location', list_location)
cli_command('account list-locations', list_locations)