Accept TraceContext from host - #244
Merged
Yogesh Jagadeesan (yojagad) merged 1 commit intoSep 21, 2019
Merged
Conversation
Yogesh Jagadeesan (yojagad)
requested review from
Brett Samblanet (brettsam),
Camille (camillemarie),
Marie Hoeger (mhoeger) and
Pragna Gopa (pragnagopa)
and removed request for
Camille (camillemarie)
September 10, 2019 23:26
Yogesh Jagadeesan (yojagad)
force-pushed
the
CorrelationIdFromRuntime
branch
from
September 12, 2019 02:00
936ca57 to
843cc81
Compare
Yogesh Jagadeesan (yojagad)
requested a review
from Liudmila Molkova (lmolkova)
September 13, 2019 00:24
Marie Hoeger (mhoeger)
suggested changes
Sep 17, 2019
Marie Hoeger (mhoeger)
left a comment
Contributor
There was a problem hiding this comment.
A few comments - thanks!
Marie Hoeger (mhoeger)
suggested changes
Sep 20, 2019
Marie Hoeger (mhoeger)
left a comment
Contributor
There was a problem hiding this comment.
a few changes requested
Marie Hoeger (mhoeger)
approved these changes
Sep 21, 2019
Marie Hoeger (mhoeger)
left a comment
Contributor
There was a problem hiding this comment.
lgtm, thank you!!
Yogesh Jagadeesan (yojagad)
force-pushed
the
CorrelationIdFromRuntime
branch
from
September 21, 2019 01:14
80f3219 to
ee3d1c1
Compare
Yogesh Jagadeesan (yojagad)
force-pushed
the
CorrelationIdFromRuntime
branch
from
September 21, 2019 01:22
ee3d1c1 to
b8588ed
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fix for Azure/azure-functions-host#3747
Host PR: Azure/azure-functions-host#4917
LanguageWorker PR: Azure/azure-functions-language-worker-protobuf#40