Skip to content

App Config Spring AOP Aspect fix - #40452

Merged
Xiaolu Dai (saragluna) merged 1 commit into
Azure:feature/spring-boot-3from
mrm9084:EndpointFix3
Jun 4, 2024
Merged

Xiaolu Dai (saragluna) merged 1 commit into
Azure:feature/spring-boot-3from
mrm9084:EndpointFix3

Conversation

@mrm9084

@mrm9084 Matthew Metcalf (mrm9084) commented Jun 3, 2024

Copy link
Copy Markdown
Member

Description

When a Spring AOP Aspect attempts to be added to all request mappings an error happens as our endpoints are marked as final.

This should solve the issue for when something like @Before("execution(@(@org.springframework.web.bind.annotation.RequestMapping *) * *(..))") being added to an @Aspect.

Until this is merged a more specific item would need to be checked. Or have auto refreshed disabled.

Fixes: Azure/AppConfiguration#917

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@saragluna
Xiaolu Dai (saragluna) merged commit 9aaaed6 into Azure:feature/spring-boot-3 Jun 4, 2024
Muyao Feng (Netyyyy) pushed a commit to Netyyyy/azure-sdk-for-java that referenced this pull request Jun 4, 2024
Muyao Feng (Netyyyy) added a commit that referenced this pull request Jun 6, 2024
* update version client

* update v/c/r

* Endpoint Fix (#40452)

* Fixing issues for API review. (#40489) (#40495)

---------

Co-authored-by: Matthew Metcalf <mrm9084@gmail.com>
Co-authored-by: Trevor Anderson <63077034+trande4884@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants