Make Azure KeyVault Secrets Py3 only - #22192
Merged
Merged
Conversation
Laurent Mazuel (lmazuel)
requested review from
Laia Patiño (laiapat) and
Scott Beddall (scbedd)
December 16, 2021 00:43
Laurent Mazuel (lmazuel)
requested review from
Yalin Li (YalinLi0312),
Charles Lowell (chlowell) and
Scott Schaab (schaabs)
as code owners
December 16, 2021 00:43
Laurent Mazuel (lmazuel)
requested review from
Ben Broderick Phillips (benbp) and
Wes Haggard (weshaggard)
as code owners
December 16, 2021 01:15
Member
|
Laurent Mazuel (@lmazuel) there is a single adjustment that I added. Making our common python version be |
| # a-b-c => a.b.c | ||
| NAMESPACE_NAME = PACKAGE_NAME.replace("-", ".") | ||
|
|
||
| # azure v0.x is not compatible with this package |
Contributor
There was a problem hiding this comment.
Scott Beddall (@scbedd) should these changes also be made in azure-template?
Closed
Hödd (hildurhodd)
pushed a commit
to hildurhodd/azure-sdk-for-python
that referenced
this pull request
Jan 4, 2022
* Make Azure KeyVault Secrets Py3 only * swap build/analyze to python 3.9 * Update README.md Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Rakshith Bhyravabhotla (rakshith91)
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
* Make Azure KeyVault Secrets Py3 only * swap build/analyze to python 3.9 * Update README.md Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.