Generate and implement Face SDK via TypeSpec - #35384

Merged
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom
zihyunting:azure-ai-vision-face-test-cases-and-samples
May 16, 2024
Merged

Generate and implement Face SDK via TypeSpec#35384
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom
zihyunting:azure-ai-vision-face-test-cases-and-samples

Conversation

@zihyunting

@zihyuntingzihyunting commented Apr 26, 2024

Copy link
Copy Markdown
Member

Description

This PR contains:

ToDo:

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actionsgithub-actionsBot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Apr 26, 2024
@github-actions

github-actionsBot commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution zihyunting! We will review the pull request and get back to you soon.

SDKAutoand others added 5 commits April 30, 2024 04:13
SDKAuto
CodeGen from PR 27576 in Azure/azure-rest-api-specs
f0b87e2
Merge 482ba279cb21fbf7f4e6bbd4ad14b6c14aa979d7 into b8af2fc3af08e42d2df6f48d1c84070ef1f6589b
@zihyunting
Fix SDK error
dae9679
@zihyunting
SDK Customization
2673dbd
@zihyunting
test-resources.json
de6d3d9
@zihyunting
Samples
dfc57f5
@zihyunting
zihyuntingforce-pushed the azure-ai-vision-face-test-cases-and-samples branch 2 times, most recently from d0d8ad2 to 931b3a6CompareApril 30, 2024 14:31
kristapratico
Krista Pratico (kristapratico) reviewed May 1, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md Outdated
Comment threadsdk/face/azure-ai-vision-face/README.md Outdated
Comment threadsdk/face/azure-ai-vision-face/README.md Outdated
Comment threadsdk/face/azure-ai-vision-face/README.md Outdated
Comment threadsdk/face/azure-ai-vision-face/README.md Outdated
Comment threadsdk/face/azure-ai-vision-face/samples/_shared/constants.py Outdated
Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py Outdated
Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py Outdated
Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_find_similar_faces_async.py Outdated
Comment threadsdk/face/azure-ai-vision-face/tests/preparers.py
@kristapratico

Krista Pratico (kristapratico) commented May 1, 2024

Copy link
Copy Markdown
Contributor

/azp run prepare-pipelines

@azure-pipelines

azure-pipelinesBot commented May 1, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Han-msft
Han Chiang (Han-msft) reviewed May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md Outdated
Han-msft
Han Chiang (Han-msft) reviewed May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md Outdated
Han-msft
Han Chiang (Han-msft) reviewed May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md Outdated
Han-msft
Han Chiang (Han-msft) reviewed May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md Outdated
Han-msft
Han Chiang (Han-msft) reviewed May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md Outdated
@zihyunting

zihyunting commented May 3, 2024

Copy link
Copy Markdown
MemberAuthor

/azp run prepare-pipelines

@azure-pipelines

azure-pipelinesBot commented May 3, 2024

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 35384 in repo Azure/azure-sdk-for-python

@zihyuntingzihyunting mentioned this pull request May 3, 2024
Merged
@msyyc

Yuchao Yan (msyyc) commented May 9, 2024•
edited
Loading

Copy link
Copy Markdown
Member

zihyunting Please make sure CI passed for all these items:
image
nit: The Details link contain detailed log info and you can fix with those info

@zihyunting
zihyuntingforce-pushed the azure-ai-vision-face-test-cases-and-samples branch from fc30b3c to c422332CompareMay 9, 2024 10:18
@zihyunting
zihyuntingforce-pushed the azure-ai-vision-face-test-cases-and-samples branch from 6dc4672 to 85554abCompareMay 9, 2024 12:39
msyyc
Yuchao Yan (msyyc) reviewed May 10, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py Outdated
@zihyunting
zihyuntingforce-pushed the azure-ai-vision-face-test-cases-and-samples branch 2 times, most recently from 4e3b11e to 85554abCompareMay 10, 2024 10:29
kristapratico
Krista Pratico (kristapratico) reviewed May 14, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md Outdated
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/aio/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/models/_patch.py
Comment threadsdk/face/azure-ai-vision-face/samples/samples_authentication.py Outdated
msyyc
Yuchao Yan (msyyc) approved these changes May 15, 2024
View reviewed changes

@msyycYuchao Yan (msyyc) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. It will be better if you could use black to format the code snippet in README.md.

pip install black
black myfile.py -l 120

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Han-msftHan Chiang (Han-msft)Han-msft left review comments
@catalinaperaltacatalinaperaltacatalinaperalta left review comments
@msyycYuchao Yan (msyyc)msyyc approved these changes
@lmazuelLaurent Mazuel (lmazuel)Awaiting requested review from lmazuel
+1 more reviewer
@kristapraticoKrista Pratico (kristapratico)kristapratico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Community ContributionCommunity members are working on the issuecustomer-reportedIssues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zihyunting@kristapratico@azure-sdk@msyyc@Han-msft@catalinaperalta
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Generate and implement Face SDK via TypeSpec - #35384
Merged
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
May 16, 2024
Merged
Generate and implement Face SDK via TypeSpec#35384
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
Conversation
@zihyunting
@zihyuntingzihyunting
commented
Apr 26, 2024

Copy link


Copy Markdown

Member
Description
This PR contains:
ToDo:
All SDK Contribution checklist:
  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
General Guidelines and Best Practices
  •  Title of the pull request is clear and informative.
  •  There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
Testing Guidelines
  •  Pull request includes test coverage for the included changes.
@github-actionsgithub-actionsBot
added

Community Contribution
Community members are working on the issue
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
labels
Apr 26, 2024
@github-actions
github-actionsBot
commented
Apr 26, 2024

Copy link


Copy Markdown

Contributor
Thank you for your contribution zihyunting! We will review the pull request and get back to you soon.
SDKAutoand others
added 5 commits
April 30, 2024 04:13
SDKAuto
CodeGen from PR 27576 in Azure/azure-rest-api-specs
f0b87e2
Merge 482ba279cb21fbf7f4e6bbd4ad14b6c14aa979d7 into b8af2fc3af08e42d2df6f48d1c84070ef1f6589b
@zihyunting
Fix SDK error
dae9679
@zihyunting
SDK Customization
2673dbd
@zihyunting
test-resources.json
de6d3d9
@zihyunting
Samples
dfc57f5
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
d0d8ad2 to
931b3a6CompareApril 30, 2024 14:31
kristapratico
Krista Pratico (kristapratico)
reviewed
May 1, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/_shared/constants.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_find_similar_faces_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/tests/preparers.py
@kristapratico
Krista Pratico (kristapratico)
commented
May 1, 2024

Copy link


Copy Markdown

Contributor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 1, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

@zihyunting
zihyunting
commented
May 3, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2024

Copy link


Copy Markdown


Commenter does not have sufficient privileges for PR 35384 in repo Azure/azure-sdk-for-python
@zihyuntingzihyunting
mentioned this pull request
May 3, 2024
 Merged

@msyyc
Yuchao Yan (msyyc)
commented
May 9, 2024•

edited

Loading

Copy link


Copy Markdown

Member
zihyunting Please make sure CI passed for all these items:
image

nit: The Details link contain detailed log info and you can fix with those info
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
fc30b3c to
c422332CompareMay 9, 2024 10:18
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
6dc4672 to
85554abCompareMay 9, 2024 12:39
msyyc
Yuchao Yan (msyyc)
reviewed
May 10, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Outdated

@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
4e3b11e to
85554abCompareMay 10, 2024 10:29
kristapratico
Krista Pratico (kristapratico)
reviewed
May 14, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/aio/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/models/_patch.py
Comment threadsdk/face/azure-ai-vision-face/samples/samples_authentication.py
Outdated

msyyc
Yuchao Yan (msyyc)
approved these changes
May 15, 2024
View reviewed changes
@msyycYuchao Yan (msyyc)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. It will be better if you could use black to format the code snippet in README.md.
pip install black
black myfile.py -l 120

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Han-msftHan Chiang (Han-msft)Han-msft left review comments
@catalinaperaltacatalinaperaltacatalinaperalta left review comments
@msyycYuchao Yan (msyyc)msyyc approved these changes
@lmazuelLaurent Mazuel (lmazuel)Awaiting requested review from lmazuel

+1 more reviewer

@kristapraticoKrista Pratico (kristapratico)kristapratico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Community ContributionCommunity members are working on the issuecustomer-reportedIssues that are reported by GitHub users external to the Azure organization.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@zihyunting@kristapratico@azure-sdk@msyyc@Han-msft@catalinaperalta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Generate and implement Face SDK via TypeSpec - #35384
Merged
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
May 16, 2024
Merged
Generate and implement Face SDK via TypeSpec#35384
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
Conversation
@zihyunting
@zihyuntingzihyunting
commented
Apr 26, 2024

Copy link


Copy Markdown

Member
Description
This PR contains:
ToDo:
All SDK Contribution checklist:
  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
General Guidelines and Best Practices
  •  Title of the pull request is clear and informative.
  •  There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
Testing Guidelines
  •  Pull request includes test coverage for the included changes.
@github-actionsgithub-actionsBot
added

Community Contribution
Community members are working on the issue
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
labels
Apr 26, 2024
@github-actions
github-actionsBot
commented
Apr 26, 2024

Copy link


Copy Markdown

Contributor
Thank you for your contribution zihyunting! We will review the pull request and get back to you soon.
SDKAutoand others
added 5 commits
April 30, 2024 04:13
SDKAuto
CodeGen from PR 27576 in Azure/azure-rest-api-specs
f0b87e2
Merge 482ba279cb21fbf7f4e6bbd4ad14b6c14aa979d7 into b8af2fc3af08e42d2df6f48d1c84070ef1f6589b
@zihyunting
Fix SDK error
dae9679
@zihyunting
SDK Customization
2673dbd
@zihyunting
test-resources.json
de6d3d9
@zihyunting
Samples
dfc57f5
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
d0d8ad2 to
931b3a6CompareApril 30, 2024 14:31
kristapratico
Krista Pratico (kristapratico)
reviewed
May 1, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/_shared/constants.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_find_similar_faces_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/tests/preparers.py
@kristapratico
Krista Pratico (kristapratico)
commented
May 1, 2024

Copy link


Copy Markdown

Contributor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 1, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

@zihyunting
zihyunting
commented
May 3, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2024

Copy link


Copy Markdown


Commenter does not have sufficient privileges for PR 35384 in repo Azure/azure-sdk-for-python
@zihyuntingzihyunting
mentioned this pull request
May 3, 2024
 Merged

@msyyc
Yuchao Yan (msyyc)
commented
May 9, 2024•

edited

Loading

Copy link


Copy Markdown

Member
zihyunting Please make sure CI passed for all these items:
image

nit: The Details link contain detailed log info and you can fix with those info
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
fc30b3c to
c422332CompareMay 9, 2024 10:18
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
6dc4672 to
85554abCompareMay 9, 2024 12:39
msyyc
Yuchao Yan (msyyc)
reviewed
May 10, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Outdated

@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
4e3b11e to
85554abCompareMay 10, 2024 10:29
kristapratico
Krista Pratico (kristapratico)
reviewed
May 14, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/aio/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/models/_patch.py
Comment threadsdk/face/azure-ai-vision-face/samples/samples_authentication.py
Outdated

msyyc
Yuchao Yan (msyyc)
approved these changes
May 15, 2024
View reviewed changes
@msyycYuchao Yan (msyyc)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. It will be better if you could use black to format the code snippet in README.md.
pip install black
black myfile.py -l 120

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Han-msftHan Chiang (Han-msft)Han-msft left review comments
@catalinaperaltacatalinaperaltacatalinaperalta left review comments
@msyycYuchao Yan (msyyc)msyyc approved these changes
@lmazuelLaurent Mazuel (lmazuel)Awaiting requested review from lmazuel

+1 more reviewer

@kristapraticoKrista Pratico (kristapratico)kristapratico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Community ContributionCommunity members are working on the issuecustomer-reportedIssues that are reported by GitHub users external to the Azure organization.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@zihyunting@kristapratico@azure-sdk@msyyc@Han-msft@catalinaperalta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Generate and implement Face SDK via TypeSpec - #35384
Merged
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
May 16, 2024
Merged
Generate and implement Face SDK via TypeSpec#35384
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
Conversation
@zihyunting
@zihyuntingzihyunting
commented
Apr 26, 2024

Copy link


Copy Markdown

Member
Description
This PR contains:
ToDo:
All SDK Contribution checklist:
  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
General Guidelines and Best Practices
  •  Title of the pull request is clear and informative.
  •  There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
Testing Guidelines
  •  Pull request includes test coverage for the included changes.
@github-actionsgithub-actionsBot
added

Community Contribution
Community members are working on the issue
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
labels
Apr 26, 2024
@github-actions
github-actionsBot
commented
Apr 26, 2024

Copy link


Copy Markdown

Contributor
Thank you for your contribution zihyunting! We will review the pull request and get back to you soon.
SDKAutoand others
added 5 commits
April 30, 2024 04:13
SDKAuto
CodeGen from PR 27576 in Azure/azure-rest-api-specs
f0b87e2
Merge 482ba279cb21fbf7f4e6bbd4ad14b6c14aa979d7 into b8af2fc3af08e42d2df6f48d1c84070ef1f6589b
@zihyunting
Fix SDK error
dae9679
@zihyunting
SDK Customization
2673dbd
@zihyunting
test-resources.json
de6d3d9
@zihyunting
Samples
dfc57f5
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
d0d8ad2 to
931b3a6CompareApril 30, 2024 14:31
kristapratico
Krista Pratico (kristapratico)
reviewed
May 1, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/_shared/constants.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_find_similar_faces_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/tests/preparers.py
@kristapratico
Krista Pratico (kristapratico)
commented
May 1, 2024

Copy link


Copy Markdown

Contributor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 1, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

@zihyunting
zihyunting
commented
May 3, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2024

Copy link


Copy Markdown


Commenter does not have sufficient privileges for PR 35384 in repo Azure/azure-sdk-for-python
@zihyuntingzihyunting
mentioned this pull request
May 3, 2024
 Merged

@msyyc
Yuchao Yan (msyyc)
commented
May 9, 2024•

edited

Loading

Copy link


Copy Markdown

Member
zihyunting Please make sure CI passed for all these items:
image

nit: The Details link contain detailed log info and you can fix with those info
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
fc30b3c to
c422332CompareMay 9, 2024 10:18
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
6dc4672 to
85554abCompareMay 9, 2024 12:39
msyyc
Yuchao Yan (msyyc)
reviewed
May 10, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Outdated

@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
4e3b11e to
85554abCompareMay 10, 2024 10:29
kristapratico
Krista Pratico (kristapratico)
reviewed
May 14, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/aio/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/models/_patch.py
Comment threadsdk/face/azure-ai-vision-face/samples/samples_authentication.py
Outdated

msyyc
Yuchao Yan (msyyc)
approved these changes
May 15, 2024
View reviewed changes
@msyycYuchao Yan (msyyc)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. It will be better if you could use black to format the code snippet in README.md.
pip install black
black myfile.py -l 120

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Han-msftHan Chiang (Han-msft)Han-msft left review comments
@catalinaperaltacatalinaperaltacatalinaperalta left review comments
@msyycYuchao Yan (msyyc)msyyc approved these changes
@lmazuelLaurent Mazuel (lmazuel)Awaiting requested review from lmazuel

+1 more reviewer

@kristapraticoKrista Pratico (kristapratico)kristapratico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Community ContributionCommunity members are working on the issuecustomer-reportedIssues that are reported by GitHub users external to the Azure organization.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@zihyunting@kristapratico@azure-sdk@msyyc@Han-msft@catalinaperalta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Generate and implement Face SDK via TypeSpec - #35384
Merged
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
May 16, 2024
Merged
Generate and implement Face SDK via TypeSpec#35384
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
Conversation
@zihyunting
@zihyuntingzihyunting
commented
Apr 26, 2024

Copy link


Copy Markdown

Member
Description
This PR contains:
ToDo:
All SDK Contribution checklist:
  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
General Guidelines and Best Practices
  •  Title of the pull request is clear and informative.
  •  There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
Testing Guidelines
  •  Pull request includes test coverage for the included changes.
@github-actionsgithub-actionsBot
added

Community Contribution
Community members are working on the issue
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
labels
Apr 26, 2024
@github-actions
github-actionsBot
commented
Apr 26, 2024

Copy link


Copy Markdown

Contributor
Thank you for your contribution zihyunting! We will review the pull request and get back to you soon.
SDKAutoand others
added 5 commits
April 30, 2024 04:13
SDKAuto
CodeGen from PR 27576 in Azure/azure-rest-api-specs
f0b87e2
Merge 482ba279cb21fbf7f4e6bbd4ad14b6c14aa979d7 into b8af2fc3af08e42d2df6f48d1c84070ef1f6589b
@zihyunting
Fix SDK error
dae9679
@zihyunting
SDK Customization
2673dbd
@zihyunting
test-resources.json
de6d3d9
@zihyunting
Samples
dfc57f5
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
d0d8ad2 to
931b3a6CompareApril 30, 2024 14:31
kristapratico
Krista Pratico (kristapratico)
reviewed
May 1, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/_shared/constants.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_find_similar_faces_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/tests/preparers.py
@kristapratico
Krista Pratico (kristapratico)
commented
May 1, 2024

Copy link


Copy Markdown

Contributor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 1, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

@zihyunting
zihyunting
commented
May 3, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2024

Copy link


Copy Markdown


Commenter does not have sufficient privileges for PR 35384 in repo Azure/azure-sdk-for-python
@zihyuntingzihyunting
mentioned this pull request
May 3, 2024
 Merged

@msyyc
Yuchao Yan (msyyc)
commented
May 9, 2024•

edited

Loading

Copy link


Copy Markdown

Member
zihyunting Please make sure CI passed for all these items:
image

nit: The Details link contain detailed log info and you can fix with those info
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
fc30b3c to
c422332CompareMay 9, 2024 10:18
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
6dc4672 to
85554abCompareMay 9, 2024 12:39
msyyc
Yuchao Yan (msyyc)
reviewed
May 10, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Outdated

@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
4e3b11e to
85554abCompareMay 10, 2024 10:29
kristapratico
Krista Pratico (kristapratico)
reviewed
May 14, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/aio/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/models/_patch.py
Comment threadsdk/face/azure-ai-vision-face/samples/samples_authentication.py
Outdated

msyyc
Yuchao Yan (msyyc)
approved these changes
May 15, 2024
View reviewed changes
@msyycYuchao Yan (msyyc)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. It will be better if you could use black to format the code snippet in README.md.
pip install black
black myfile.py -l 120

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Han-msftHan Chiang (Han-msft)Han-msft left review comments
@catalinaperaltacatalinaperaltacatalinaperalta left review comments
@msyycYuchao Yan (msyyc)msyyc approved these changes
@lmazuelLaurent Mazuel (lmazuel)Awaiting requested review from lmazuel

+1 more reviewer

@kristapraticoKrista Pratico (kristapratico)kristapratico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Community ContributionCommunity members are working on the issuecustomer-reportedIssues that are reported by GitHub users external to the Azure organization.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@zihyunting@kristapratico@azure-sdk@msyyc@Han-msft@catalinaperalta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Generate and implement Face SDK via TypeSpec - #35384
Merged
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
May 16, 2024
Merged
Generate and implement Face SDK via TypeSpec#35384
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
Conversation
@zihyunting
@zihyuntingzihyunting
commented
Apr 26, 2024

Copy link


Copy Markdown

Member
Description
This PR contains:
ToDo:
All SDK Contribution checklist:
  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
General Guidelines and Best Practices
  •  Title of the pull request is clear and informative.
  •  There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
Testing Guidelines
  •  Pull request includes test coverage for the included changes.
@github-actionsgithub-actionsBot
added

Community Contribution
Community members are working on the issue
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
labels
Apr 26, 2024
@github-actions
github-actionsBot
commented
Apr 26, 2024

Copy link


Copy Markdown

Contributor
Thank you for your contribution zihyunting! We will review the pull request and get back to you soon.
SDKAutoand others
added 5 commits
April 30, 2024 04:13
SDKAuto
CodeGen from PR 27576 in Azure/azure-rest-api-specs
f0b87e2
Merge 482ba279cb21fbf7f4e6bbd4ad14b6c14aa979d7 into b8af2fc3af08e42d2df6f48d1c84070ef1f6589b
@zihyunting
Fix SDK error
dae9679
@zihyunting
SDK Customization
2673dbd
@zihyunting
test-resources.json
de6d3d9
@zihyunting
Samples
dfc57f5
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
d0d8ad2 to
931b3a6CompareApril 30, 2024 14:31
kristapratico
Krista Pratico (kristapratico)
reviewed
May 1, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/_shared/constants.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_find_similar_faces_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/tests/preparers.py
@kristapratico
Krista Pratico (kristapratico)
commented
May 1, 2024

Copy link


Copy Markdown

Contributor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 1, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

@zihyunting
zihyunting
commented
May 3, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2024

Copy link


Copy Markdown


Commenter does not have sufficient privileges for PR 35384 in repo Azure/azure-sdk-for-python
@zihyuntingzihyunting
mentioned this pull request
May 3, 2024
 Merged

@msyyc
Yuchao Yan (msyyc)
commented
May 9, 2024•

edited

Loading

Copy link


Copy Markdown

Member
zihyunting Please make sure CI passed for all these items:
image

nit: The Details link contain detailed log info and you can fix with those info
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
fc30b3c to
c422332CompareMay 9, 2024 10:18
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
6dc4672 to
85554abCompareMay 9, 2024 12:39
msyyc
Yuchao Yan (msyyc)
reviewed
May 10, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Outdated

@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
4e3b11e to
85554abCompareMay 10, 2024 10:29
kristapratico
Krista Pratico (kristapratico)
reviewed
May 14, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/aio/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/models/_patch.py
Comment threadsdk/face/azure-ai-vision-face/samples/samples_authentication.py
Outdated

msyyc
Yuchao Yan (msyyc)
approved these changes
May 15, 2024
View reviewed changes
@msyycYuchao Yan (msyyc)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. It will be better if you could use black to format the code snippet in README.md.
pip install black
black myfile.py -l 120

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Han-msftHan Chiang (Han-msft)Han-msft left review comments
@catalinaperaltacatalinaperaltacatalinaperalta left review comments
@msyycYuchao Yan (msyyc)msyyc approved these changes
@lmazuelLaurent Mazuel (lmazuel)Awaiting requested review from lmazuel

+1 more reviewer

@kristapraticoKrista Pratico (kristapratico)kristapratico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Community ContributionCommunity members are working on the issuecustomer-reportedIssues that are reported by GitHub users external to the Azure organization.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@zihyunting@kristapratico@azure-sdk@msyyc@Han-msft@catalinaperalta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Generate and implement Face SDK via TypeSpec - #35384
Merged
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
May 16, 2024
Merged
Generate and implement Face SDK via TypeSpec#35384
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
Conversation
@zihyunting
@zihyuntingzihyunting
commented
Apr 26, 2024

Copy link


Copy Markdown

Member
Description
This PR contains:
ToDo:
All SDK Contribution checklist:
  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
General Guidelines and Best Practices
  •  Title of the pull request is clear and informative.
  •  There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
Testing Guidelines
  •  Pull request includes test coverage for the included changes.
@github-actionsgithub-actionsBot
added

Community Contribution
Community members are working on the issue
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
labels
Apr 26, 2024
@github-actions
github-actionsBot
commented
Apr 26, 2024

Copy link


Copy Markdown

Contributor
Thank you for your contribution zihyunting! We will review the pull request and get back to you soon.
SDKAutoand others
added 5 commits
April 30, 2024 04:13
SDKAuto
CodeGen from PR 27576 in Azure/azure-rest-api-specs
f0b87e2
Merge 482ba279cb21fbf7f4e6bbd4ad14b6c14aa979d7 into b8af2fc3af08e42d2df6f48d1c84070ef1f6589b
@zihyunting
Fix SDK error
dae9679
@zihyunting
SDK Customization
2673dbd
@zihyunting
test-resources.json
de6d3d9
@zihyunting
Samples
dfc57f5
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
d0d8ad2 to
931b3a6CompareApril 30, 2024 14:31
kristapratico
Krista Pratico (kristapratico)
reviewed
May 1, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/_shared/constants.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_find_similar_faces_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/tests/preparers.py
@kristapratico
Krista Pratico (kristapratico)
commented
May 1, 2024

Copy link


Copy Markdown

Contributor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 1, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

@zihyunting
zihyunting
commented
May 3, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2024

Copy link


Copy Markdown


Commenter does not have sufficient privileges for PR 35384 in repo Azure/azure-sdk-for-python
@zihyuntingzihyunting
mentioned this pull request
May 3, 2024
 Merged

@msyyc
Yuchao Yan (msyyc)
commented
May 9, 2024•

edited

Loading

Copy link


Copy Markdown

Member
zihyunting Please make sure CI passed for all these items:
image

nit: The Details link contain detailed log info and you can fix with those info
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
fc30b3c to
c422332CompareMay 9, 2024 10:18
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
6dc4672 to
85554abCompareMay 9, 2024 12:39
msyyc
Yuchao Yan (msyyc)
reviewed
May 10, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Outdated

@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
4e3b11e to
85554abCompareMay 10, 2024 10:29
kristapratico
Krista Pratico (kristapratico)
reviewed
May 14, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/aio/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/models/_patch.py
Comment threadsdk/face/azure-ai-vision-face/samples/samples_authentication.py
Outdated

msyyc
Yuchao Yan (msyyc)
approved these changes
May 15, 2024
View reviewed changes
@msyycYuchao Yan (msyyc)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. It will be better if you could use black to format the code snippet in README.md.
pip install black
black myfile.py -l 120

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Han-msftHan Chiang (Han-msft)Han-msft left review comments
@catalinaperaltacatalinaperaltacatalinaperalta left review comments
@msyycYuchao Yan (msyyc)msyyc approved these changes
@lmazuelLaurent Mazuel (lmazuel)Awaiting requested review from lmazuel

+1 more reviewer

@kristapraticoKrista Pratico (kristapratico)kristapratico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Community ContributionCommunity members are working on the issuecustomer-reportedIssues that are reported by GitHub users external to the Azure organization.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@zihyunting@kristapratico@azure-sdk@msyyc@Han-msft@catalinaperalta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Generate and implement Face SDK via TypeSpec - #35384
Merged
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
May 16, 2024
Merged
Generate and implement Face SDK via TypeSpec#35384
Krista Pratico (kristapratico) merged 42 commits into
Azure:mainfrom 
zihyunting:azure-ai-vision-face-test-cases-and-samples
Conversation
@zihyunting
@zihyuntingzihyunting
commented
Apr 26, 2024

Copy link


Copy Markdown

Member
Description
This PR contains:
ToDo:
All SDK Contribution checklist:
  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
General Guidelines and Best Practices
  •  Title of the pull request is clear and informative.
  •  There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
Testing Guidelines
  •  Pull request includes test coverage for the included changes.
@github-actionsgithub-actionsBot
added

Community Contribution
Community members are working on the issue
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
labels
Apr 26, 2024
@github-actions
github-actionsBot
commented
Apr 26, 2024

Copy link


Copy Markdown

Contributor
Thank you for your contribution zihyunting! We will review the pull request and get back to you soon.
SDKAutoand others
added 5 commits
April 30, 2024 04:13
SDKAuto
CodeGen from PR 27576 in Azure/azure-rest-api-specs
f0b87e2
Merge 482ba279cb21fbf7f4e6bbd4ad14b6c14aa979d7 into b8af2fc3af08e42d2df6f48d1c84070ef1f6589b
@zihyunting
Fix SDK error
dae9679
@zihyunting
SDK Customization
2673dbd
@zihyunting
test-resources.json
de6d3d9
@zihyunting
Samples
dfc57f5
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
d0d8ad2 to
931b3a6CompareApril 30, 2024 14:31
kristapratico
Krista Pratico (kristapratico)
reviewed
May 1, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/_shared/constants.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_authentication_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/samples/async_samples/samples_find_similar_faces_async.py
Outdated

Comment threadsdk/face/azure-ai-vision-face/tests/preparers.py
@kristapratico
Krista Pratico (kristapratico)
commented
May 1, 2024

Copy link


Copy Markdown

Contributor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 1, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Han-msft
Han Chiang (Han-msft)
reviewed
May 3, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

@zihyunting
zihyunting
commented
May 3, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run prepare-pipelines
@azure-pipelines
azure-pipelinesBot
commented
May 3, 2024

Copy link


Copy Markdown


Commenter does not have sufficient privileges for PR 35384 in repo Azure/azure-sdk-for-python
@zihyuntingzihyunting
mentioned this pull request
May 3, 2024
 Merged

@msyyc
Yuchao Yan (msyyc)
commented
May 9, 2024•

edited

Loading

Copy link


Copy Markdown

Member
zihyunting Please make sure CI passed for all these items:
image

nit: The Details link contain detailed log info and you can fix with those info
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
fc30b3c to
c422332CompareMay 9, 2024 10:18
@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
from
6dc4672 to
85554abCompareMay 9, 2024 12:39
msyyc
Yuchao Yan (msyyc)
reviewed
May 10, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Outdated

@zihyunting
zihyuntingforce-pushed
the
azure-ai-vision-face-test-cases-and-samples
branch
2 times, most recently
from
4e3b11e to
85554abCompareMay 10, 2024 10:29
kristapratico
Krista Pratico (kristapratico)
reviewed
May 14, 2024
View reviewed changes
Comment threadsdk/face/azure-ai-vision-face/README.md
Outdated

Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/aio/_patch.py
Comment threadsdk/face/azure-ai-vision-face/azure/ai/vision/face/models/_patch.py
Comment threadsdk/face/azure-ai-vision-face/samples/samples_authentication.py
Outdated

msyyc
Yuchao Yan (msyyc)
approved these changes
May 15, 2024
View reviewed changes
@msyycYuchao Yan (msyyc)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. It will be better if you could use black to format the code snippet in README.md.
pip install black
black myfile.py -l 120

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Han-msftHan Chiang (Han-msft)Han-msft left review comments
@catalinaperaltacatalinaperaltacatalinaperalta left review comments
@msyycYuchao Yan (msyyc)msyyc approved these changes
@lmazuelLaurent Mazuel (lmazuel)Awaiting requested review from lmazuel

+1 more reviewer

@kristapraticoKrista Pratico (kristapratico)kristapratico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Community ContributionCommunity members are working on the issuecustomer-reportedIssues that are reported by GitHub users external to the Azure organization.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@zihyunting@kristapratico@azure-sdk@msyyc@Han-msft@catalinaperalta