Uh oh!
There was an error while loading. Please reload this page.
[2203] Add PS Cmdlets for VPN Admin API - #151
Conversation
Ian (iancaragol)
commented
Mar 31, 2022
/azp run |
|
Commenter does not have sufficient privileges for PR 151 in repo Azure/azurestack-powershell |
| @@ -0,0 +1,25 @@ | |||
| @{ | |||
| GUID = '70926bce-bc6d-44d9-9c7c-04173e27f5c9' | |||
There was a problem hiding this comment.
This file should not be checked in, it gets generated and modified with the metadata specified in the readme.md
There was a problem hiding this comment.
Thanks I removed it
bganapa
left a comment
There was a problem hiding this comment.
Update module version and the changelog. code review checklist has pointers
https://github.com/Azure/azurestack-powershell/wiki/Code-Review-Check-List
bganapa
commented
Mar 31, 2022
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Ian (iancaragol)
commented
Apr 1, 2022
Thanks bganapa! I bumped the module version from 1.0.2 to 1.1.0 and also updated the changelog.md |
Wei Shi (TheOnlyWei)
commented
Apr 4, 2022
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Ian (iancaragol)
commented
Apr 4, 2022
Wei Shi (@TheOnlyWei) It looks like the CI run failed on the Backup.Admin tests. This should be unrelated to my changes. Is it a known issue? |
Yes, it is a known issue. Backup RP is attempting to revert their changes due to some issues, don't know about ETA. I can force merge your changes as long as you haven't made changes to the RP that is failing. |
Ian (iancaragol)
commented
Apr 6, 2022
We would prefer to go the force merge route if that is OK with you. That way everything is checked in and ready to go. I have only made changes within the AzS.Network.Admin space Thanks! |
Wei Shi (TheOnlyWei)
commented
Apr 12, 2022
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
The main new addition is the Get-AzSVirtualNetworkGatewayConnection cmdlet which uses talks to NRP to list all VPN resources created on the stamp.
As part of the generation for this cmdlet, many other files were updated as well. The docs MD file for each of the other cmdlet has a new format.
Please let me know if I need to remove these updates.
Thanks!