Skip to content

feat: Added WhatIf support to Test-ModuleLocally script + several smaller bugfixes - #679

Merged
Alexander Sehr (AlexanderSehr) merged 58 commits into
Azure:mainfrom
AlexanderSehr:users/alsehr/whatIfPort
Nov 30, 2023
Merged

feat: Added WhatIf support to Test-ModuleLocally script + several smaller bugfixes#679
Alexander Sehr (AlexanderSehr) merged 58 commits into
Azure:mainfrom
AlexanderSehr:users/alsehr/whatIfPort

Conversation

@AlexanderSehr

@AlexanderSehr Alexander Sehr (AlexanderSehr) commented Nov 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

@AlexanderSehr
Added skeleton
20ac8b7
@AlexanderSehr
Implemented first new tests
4939b4d
@AlexanderSehr
Changed to warning
4e1d86f
@AlexanderSehr
Expanded test verbosity & added additional tets
94fff0b
@AlexanderSehr
Finalized further tests
c18ce6b
@AlexanderSehr
Update to latest
a343694
@AlexanderSehr
Update to latest
3a6f0a2
@AlexanderSehr
Added module name + small fix
4ab6a5b
@AlexanderSehr
Fixed kvlt
9bb64bd
@AlexanderSehr
Small caching fix
68e2bd2
@AlexanderSehr
Small fix and enabled passthru of warnings to GH
1a013c2
@AlexanderSehr
More updates
1c2fc8a
@AlexanderSehr
Update to latest
d9c6dd5
@AlexanderSehr
Updated test names
dd0c343
@AlexanderSehr
JSON rollback
2ebd458
@AlexanderSehr
Updated regex
f6caf7e
@AlexanderSehr
Removed assertion
f56f66a
@AlexanderSehr
Update to latest
282b640
@AlexanderSehr @eriqua
Update avm/utilities/pipelines/staticValidation/compliance/module.tes…
c025f52 
…ts.ps1

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update avm/utilities/pipelines/staticValidation/compliance/module.tes…
405901a 
…ts.ps1

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr
Merge branch 'main' into users/alsehr/testFileCompliance
904c82f
@AlexanderSehr
Rollback of unrelated changes
ef24d1f
@AlexanderSehr
Merge branch 'Azure:main' into main
9393aa1
@AlexanderSehr
Merge branch 'Azure:main' into main
cb39086
@AlexanderSehr
Merge branch 'Azure:main' into main
89eac40
@AlexanderSehr
Merge branch 'Azure:main' into main
712a673
@AlexanderSehr
Resolved conflict
55e095f
@AlexanderSehr
Update to latest
3121335
@AlexanderSehr
Merge branch 'Azure:main' into main
e9d736c
@AlexanderSehr
Merge branch 'Azure:main' into main
abfa1b9
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 28, 2023
@AlexanderSehr Alexander Sehr (AlexanderSehr) changed the title Users/alsehr/what if port feat: Added WhatIf support to Test-ModuleLocally script + several smaller bugfixes Nov 28, 2023
@ChrisSidebotham

ChrisSidebotham-MSFT (ChrisSidebotham) commented Nov 28, 2023

Copy link
Copy Markdown
Contributor

Alexander Sehr (@AlexanderSehr) - Any reason why this is expecting a review from @Azure/avm-res-operationalinsights-workspace-module-owners-bicep?

@AlexanderSehr
Alexander Sehr (AlexanderSehr) marked this pull request as draft November 29, 2023 08:01
auto-merge was automatically disabled November 29, 2023 08:01

Pull request was converted to draft

@AlexanderSehr
Alexander Sehr (AlexanderSehr) marked this pull request as ready for review November 29, 2023 08:01
@AlexanderSehr

Alexander Sehr (AlexanderSehr) commented Nov 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Alexander Sehr (@AlexanderSehr) - Any reason why this is expecting a review from @Azure/avm-res-operationalinsights-workspace-module-owners-bicep?

Hey ChrisSidebotham-MSFT (@ChrisSidebotham), not sure. I think I've seen in the log that Git was complaining about that module's encoding (-> Line-Ending) so maybe that's why. However, it's not part of the PR so it remains a bit odd. I wish I'd know :D

@ChrisSidebotham

ChrisSidebotham-MSFT (ChrisSidebotham) commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

Alexander Sehr (@AlexanderSehr)

        Alexander Sehr
        FTE - Any reason why this is expecting a review from @Azure/avm-res-operationalinsights-workspace-module-owners-bicep?

Hey ChrisSidebotham-MSFT (@ChrisSidebotham) Chris Sidebotham FTE, not sure. I think I've seen in the log that Git was complaining about that module's encoding (-> Line-Ending) so maybe that's why. However, it's not part of the PR so it remains a bit odd. I wish I'd know :D

I see there is now conflicts on this Alexander Sehr (@AlexanderSehr)

@ChrisSidebotham ChrisSidebotham-MSFT (ChrisSidebotham) added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Needs: Triage 🔍 Maintainers need to triage still labels Nov 29, 2023
@AlexanderSehr

Alexander Sehr (AlexanderSehr) commented Nov 29, 2023

Copy link
Copy Markdown
Contributor Author

Alexander Sehr (@AlexanderSehr)

        Alexander Sehr
        FTE - Any reason why this is expecting a review from @Azure/avm-res-operationalinsights-workspace-module-owners-bicep?

Hey ChrisSidebotham-MSFT (@ChrisSidebotham) Chris Sidebotham FTE, not sure. I think I've seen in the log that Git was complaining about that module's encoding (-> Line-Ending) so maybe that's why. However, it's not part of the PR so it remains a bit odd. I wish I'd know :D

I see there is now conflicts on this Alexander Sehr (@AlexanderSehr)

resolved. My fix in main was even more correct than this one :D

@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Nov 29, 2023
ChrisSidebotham
ChrisSidebotham-MSFT (ChrisSidebotham) approved these changes Nov 29, 2023
View reviewed changes

@ChrisSidebotham ChrisSidebotham-MSFT (ChrisSidebotham) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@eriqua
Erika Gressi (eriqua) marked this pull request as draft November 30, 2023 00:02
@eriqua
Erika Gressi (eriqua) marked this pull request as ready for review November 30, 2023 00:02
@AlexanderSehr
Alexander Sehr (AlexanderSehr) merged commit 3a0f5a6 into Azure:main Nov 30, 2023
@AlexanderSehr
Alexander Sehr (AlexanderSehr) deleted the users/alsehr/whatIfPort branch November 30, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisSidebotham ChrisSidebotham-MSFT (ChrisSidebotham) ChrisSidebotham approved these changes

Assignees

@AlexanderSehr Alexander Sehr (AlexanderSehr)

Labels

Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexanderSehr @ChrisSidebotham @jtracey93