Uh oh!
There was an error while loading. Please reload this page.
Add missing docs, package info and bugfixes - #100
Conversation
| public string ExecutionId { get; set; } | ||
| /// <summary> | ||
| /// Gets or sets the match type of either statrts with or exact match for the filter |
There was a problem hiding this comment.
statrts [](start = 50, length = 7)
typo
| namespace DurableTask.Core | ||
| { | ||
| /// <summary> | ||
| /// Filter for Orchestrationname and version |
| using System; | ||
| /// <summary> | ||
| /// Filter for Orchestration time range on a timerange type |
| const int FullGzipHeaderLength = 10; | ||
| /// <summary> | ||
| /// Gets a safe maximim datetime value that accounts for timezone |
| const int FullGzipHeaderLength = 10; | ||
| /// <summary> | ||
| /// Gets a safe maximim datetime value that accounts for timezone |
There was a problem hiding this comment.
maximim [](start = 24, length = 7)
typo
| /// <summary> | ||
| /// Creates a new instance of the LocalOrchestrationService with default settings | ||
| /// </summary> |
| { | ||
| DateTimeUtils.SetMinDateTimeForStorageEmulator(); | ||
| } | ||
| // Workaround an issue with Storage that throws exceptions for any date < 1600 so DateTime.Min cannot be used |
There was a problem hiding this comment.
// Workaround an issue with Storage that throws exceptions for any date < 1600 so DateTime.Min cannot be used [](start = 11, length = 110)
Is this comment still applicable?
There was a problem hiding this comment.
Yes this is specific to Azure Tables, this code was only enabled for the emulator but the newer storage SDK also needs this
Rajeev Vokkarne (rajeevmv)
commented
Jun 30, 2017
|
| } | ||
| /// <summary> | ||
| /// Writes the supplied string input to a MemoryStream, optionaly compressing the string |
There was a problem hiding this comment.
nit: optionally
should probably mention that it returns the said MemoryStream
| /// </summary> | ||
| public const int OrchestrationDefaultMaxConcurrentItems = 100; | ||
| // task activity dispatcher default constants |
| public class OrchestrationStateInstanceFilter : OrchestrationStateQueryFilter | ||
| { | ||
| /// <summary> | ||
| /// Creates a new instance of the OrchestrationStateInstanceFilter with default settings |
There was a problem hiding this comment.
nit: comment indentation here and the rest of the code doesn't match. similarly, in a few other places below
Add package info for creating nuget packages including documentation.
Add missing XML docs on public classes.
Fix bug with RaiseEvent calling create orchestration causing unneeded jumpstart entry.
Always set mindatetime for storage instance store, not just for emulator.