Skip to content

Add SetUseSeparateQueueForEntityWorkItems - #1298

Merged
andystaples merged 2 commits into
mainfrom
andystaples/storage-config-entity-setting-change
Jan 15, 2026
Merged

Add SetUseSeparateQueueForEntityWorkItems#1298
andystaples merged 2 commits into
mainfrom
andystaples/storage-config-entity-setting-change

Conversation

@andystaples

Copy link
Copy Markdown
Contributor

Allows configuring this setting after initializing AzureStorageOrchestrationService to allow post-config by extension based on worker indexing results

CopilotAI review requested due to automatic review settings January 15, 2026 19:03

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a public setter method SetUseSeparateQueueForEntityWorkItems to allow post-initialization configuration of the UseSeparateQueueForEntityWorkItems setting based on worker indexing results, and bumps the patch version from 2.8.0 to 2.8.1.

Changes:

  • Added public method SetUseSeparateQueueForEntityWorkItems to allow modification of the entity work items queue separation setting after service initialization
  • Incremented patch version from 2.8.0 to 2.8.1

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

FileDescription
src/DurableTask.AzureStorage/DurableTask.AzureStorage.csprojVersion bump from 2.8.0 to 2.8.1
src/DurableTask.AzureStorage/AzureStorageOrchestrationService.csAdded new public method to allow post-initialization modification of UseSeparateQueueForEntityWorkItems setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadsrc/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs Outdated
Comment threadsrc/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs Outdated
Comment threadsrc/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs Outdated
Comment threadsrc/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs Outdated
Comment threadsrc/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs Outdated
/// Sets the value for settings.UseSeparateQueueForEntityWorkItems, allowing modification after initialization.
/// </summary>
/// <param name="newValue"></param>
public void SetUseSeparateQueueForEntityWorkItems(bool newValue)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just make this a get/set property?

Suggested change
publicvoidSetUseSeparateQueueForEntityWorkItems(boolnewValue)
publicboolUseSeparateQueueForEntityWorkItems
{
get =>this.settings.UseSeparateQueueForEntityWorkItems;
set =>this.UseSeparateQueueForEntityWorkItems=value;
}

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - added

@andystaples
andystaples merged commit 77af69d into mainJan 15, 2026
46 checks passed
@andystaples
andystaples deleted the andystaples/storage-config-entity-setting-change branch January 15, 2026 19:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@andystaples@cgillum@sophiatev