Uh oh!
There was an error while loading. Please reload this page.
Add SetUseSeparateQueueForEntityWorkItems - #1298
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a public setter method SetUseSeparateQueueForEntityWorkItems to allow post-initialization configuration of the UseSeparateQueueForEntityWorkItems setting based on worker indexing results, and bumps the patch version from 2.8.0 to 2.8.1.
Changes:
- Added public method
SetUseSeparateQueueForEntityWorkItemsto allow modification of the entity work items queue separation setting after service initialization - Incremented patch version from 2.8.0 to 2.8.1
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/DurableTask.AzureStorage/DurableTask.AzureStorage.csproj | Version bump from 2.8.0 to 2.8.1 |
| src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs | Added new public method to allow post-initialization modification of UseSeparateQueueForEntityWorkItems setting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| /// Sets the value for settings.UseSeparateQueueForEntityWorkItems, allowing modification after initialization. | ||
| /// </summary> | ||
| /// <param name="newValue"></param> | ||
| public void SetUseSeparateQueueForEntityWorkItems(bool newValue) |
There was a problem hiding this comment.
Should we just make this a get/set property?
| publicvoidSetUseSeparateQueueForEntityWorkItems(boolnewValue) | |
| publicboolUseSeparateQueueForEntityWorkItems | |
| { | |
| get =>this.settings.UseSeparateQueueForEntityWorkItems; | |
| set =>this.UseSeparateQueueForEntityWorkItems=value; | |
| } |
Uh oh!
There was an error while loading. Please reload this page.
Allows configuring this setting after initializing AzureStorageOrchestrationService to allow post-config by extension based on worker indexing results